dont return score struct by value, pass as pointer arg instead. fixes banking score issue strangely.

src/main.c

@@ -61,7 +61,8 @@ static void highscore(uint8_t is_black) NONBANKED {
     SHOW_WIN;
 
     for (uint8_t i = 0; i < SCORE_NUM; i++) {
-        struct scores score = is_black ? score_lowest(i) : score_highest(i);
+        struct scores score;
+        is_black ? score_lowest(i, &score) : score_highest(i, &score);
         win_score_draw(score, i, is_black);
     }
 
@@ -104,8 +105,14 @@ static void splash_win(void) NONBANKED {
         move_win(MINWNDPOSX, MINWNDPOSY);
     } else {
         // initially show the top 1 scores
-        int32_t low = score_lowest(0).score;
-        int32_t high = score_highest(0).score;
+        struct scores score;
+
+        score_lowest(0, &score);
+        int32_t low = score.score;
+
+        score_highest(0, &score);
+        int32_t high = score.score;
+
         win_splash_draw(-low, high);
 
         move_win(MINWNDPOSX, MINWNDPOSY + DEVICE_SCREEN_PX_HEIGHT - (8 * 4));

src/score.ba0.c

@@ -158,7 +158,7 @@ void score_add(struct scores score) BANKED {
     DISABLE_RAM;
 }
 
-struct scores score_highest(uint8_t off) BANKED {
+void score_highest(uint8_t off, struct scores *t) BANKED {
     ENABLE_RAM;
     SWITCH_RAM(0);
 
@@ -171,13 +171,12 @@ struct scores score_highest(uint8_t off) BANKED {
     if (off >= SCORE_NUM) {
         off = SCORE_NUM - 1;
     }
-    struct scores r = scores[off];
+    *t = scores[off];
 
     DISABLE_RAM;
-    return r;
 }
 
-struct scores score_lowest(uint8_t off) BANKED {
+void score_lowest(uint8_t off, struct scores *t) BANKED {
     ENABLE_RAM;
     SWITCH_RAM(0);
 
@@ -190,10 +189,9 @@ struct scores score_lowest(uint8_t off) BANKED {
     if (off >= SCORE_NUM) {
         off = SCORE_NUM - 1;
     }
-    struct scores r = scores[(SCORE_NUM * 2) - 1 - off];
+    *t = scores[(SCORE_NUM * 2) - 1 - off];
 
     DISABLE_RAM;
-    return r;
 }
 
 void score_reset(void) BANKED {

src/score.h

@@ -33,8 +33,8 @@ struct scores {
 uint16_t convert_name(char a, char b, char c) BANKED;
 uint8_t score_ranking(int32_t score) BANKED;
 void score_add(struct scores score) BANKED;
-struct scores score_highest(uint8_t off) BANKED;
-struct scores score_lowest(uint8_t off) BANKED;
+void score_highest(uint8_t off, struct scores *t) BANKED;
+void score_lowest(uint8_t off, struct scores *t) BANKED;
 void score_reset(void) BANKED;
 
 BANKREF_EXTERN(score)