rewrite gb printer code

src/gbprinter.c

@@ -25,356 +25,164 @@
 #include <stdio.h>
 #include <string.h>
 
-#include "gb/gb.h"
-#include "gb/hardware.h"
 #include "input.h"
+#include "window.h"
 #include "gbprinter.h"
 
 BANKREF(gbprinter)
 
-/** Width of the printed image in tiles
-*/
-#define PRN_TILE_WIDTH          20
-
-#define PRN_LOW(A) ((A) & 0xFF)
-#define PRN_HIGH(A) ((A) >> 8)
-
-/** 0x88,0x33 are mandatory first bytes to initialise a communication with printer
- *   Any command sequence begins by these
- */
-#define PRN_MAGIC               0x3388
-#define PRN_LE(A)               PRN_LOW(A),PRN_HIGH(A)
-
-/** magic number that is sent in the reply packet by the printer before the status byte
- */
-#define PRN_MAGIC_DETECT        0x81
-
-/** INIT command is mandatory to initialize communication protocol with the printer
- *   Two consecutive linked commands must never be more than 150 ms apart except the INIT command which is valid at least 10 seconds
- */
-#define PRN_CMD_INIT            0x01
-
-/** PRINT command
- *   Contains the palette, margins, number of prints and printing intensity
- */
-#define PRN_CMD_PRINT           0x02
-
-/** DATA command
- *   Can be any length between 0 and 640 bytes.
- *   DATA command with lenght 0 triggers PRN_STATUS_FULL and is mandatory before print command
- */
-#define PRN_CMD_DATA            0x04
-
-/** BREAK command
- *   Not very usefull but exists (see Game Boy Programming Manual)
- */
-#define PRN_CMD_BREAK           0x08
-
-/** STATUS command
- *   Used to check status bits
- *   Maybe be used alone before an INIT command to check physical connection with printer
- *   Resets PRN_STATUS_UNTRAN
- */
-#define PRN_CMD_STATUS          0x0F
-
-/** Palette format: the bits, grouped two by two, give the printing color of the encoded pixel value
- *   for the default palette 0xE4 = 0b11100100 = [3 2 1 0]
- *   Any value is valid, which means that 1 to 4 color images are possible
- *   0x00 acts the same as 0xE4 for the printer
- */
-#define PRN_PALETTE_NORMAL      0b11100100u
-#define PRN_PALETTE_INV         0b00011011u
-
-/** Don't use margins
- */
-#define PRN_NO_MARGINS          0x00
-
-/** Exposure: 0x40 is default value, values from 0x80 to 0xFF act as 0x40
- *   Determines the time used by the printer head to heat the thermal paper
- */
-#define PRN_EXPOSURE_LIGHT      0x00
-#define PRN_EXPOSURE_DEFAULT    0x40
-#define PRN_EXPOSURE_DARK       0x7F
-
-/** Battery too low
- */
-#define PRN_STATUS_LOWBAT       0x80
-
-/** Error not specified according to the Game Boy Programming manual
- */
-#define PRN_STATUS_ER2          0x40
-
-/** Paper jam  (abnormal motor operation)
- */
-#define PRN_STATUS_ER1          0x20
-
-/** Packet error (but not checksum error)
- */
-#define PRN_STATUS_ER0          0x10
-
-/** Unprocessed data present in printer memory
- *   Allows to verify that printer got some data in memory with correct checksum
- *   is resetted by STATUS command
- */
-#define PRN_STATUS_UNTRAN       0x08
-
-/** status data ready, mandatory to allow printing
- *   is triggered by DATA command with lenght 0
- */
-#define PRN_STATUS_FULL         0x04
-
-/** Message sent by the printer while physically printing
- */
-#define PRN_STATUS_BUSY         0x02
-
-/** The received packet has a ckecksum error
- */
-#define PRN_STATUS_SUM          0x01
-
-#define PRN_STATUS_MASK_ERRORS  0xF0
-#define PRN_STATUS_MASK_ANY     0xFF
-
-#define PRN_SECONDS(A)          ((A)*60)
-
-#define PRN_MAX_PROGRESS        8
-
-#define PRN_STATUS_CANCELLED    PRN_STATUS_ER2
-
-#define REINIT_SEIKO
-
-#define START_TRANSFER          0x81
-#define PRN_BUSY_TIMEOUT        PRN_SECONDS(2)
-#define PRN_COMPLETION_TIMEOUT  PRN_SECONDS(20)
-#define PRN_SEIKO_RESET_TIMEOUT 10
-
-#define PRN_FINAL_MARGIN        0x03
+#define PRN_TILE_WIDTH     20 // Width of the printed image in tiles
+#define PRN_MAGIC          0x3388
+#define PRN_MAGIC_DETECT   0x81 // magic reply from printer
+#define PRN_DETECT_TIMEOUT 10 // 1/6th second
+#define PRN_BUSY_TIMEOUT   (2 * 60) // 2s
+#define PRN_PRINT_TIMEOUT  (20 * 60) // 20s
+
+#define PRN_PALETTE_NORMAL 0b11100100u
+#define PRN_PALETTE_INV    0b00011011u
+
+#define PRN_NO_MARGINS     0x00
+#define PRN_FINAL_MARGIN   0x03
+
+#define PRN_EXPO_LIGHT     0x00
+#define PRN_EXPO_DEFAULT   0x40
+#define PRN_EXPO_DARK      0x7F
+
+enum PRN_CMDS {
+    PRN_CMD_INIT   = 0x01, // initialize printer
+    PRN_CMD_PRINT  = 0x02, // print command
+    PRN_CMD_DATA   = 0x04, // data command (up to 640 bytes)
+    PRN_CMD_BREAK  = 0x08,
+    PRN_CMD_STATUS = 0x0F, // query status
+};
 
-typedef struct start_print_pkt_s {
+struct prn_header {
     uint16_t magic;
-    uint16_t command;
+    uint8_t command;
+    uint8_t compression;
     uint16_t length;
-    uint8_t print;
+};
+
+struct prn_config {
+    uint8_t sheets;
     uint8_t margins;
     uint8_t palette;
     uint8_t exposure;
-    uint16_t crc;
-    uint16_t trail;
-} start_print_pkt_t;
-
-static const uint8_t PRN_PKT_INIT[] = {
-    PRN_LE(PRN_MAGIC), PRN_LE(PRN_CMD_INIT),   PRN_LE(0), PRN_LE(0x01), PRN_LE(0)
-};
-
-static const uint8_t PRN_PKT_STATUS[] = {
-    PRN_LE(PRN_MAGIC), PRN_LE(PRN_CMD_STATUS), PRN_LE(0), PRN_LE(0x0F), PRN_LE(0)
-};
-
-static const uint8_t PRN_PKT_EOF[] = {
-    PRN_LE(PRN_MAGIC), PRN_LE(PRN_CMD_DATA),   PRN_LE(0), PRN_LE(0x04), PRN_LE(0)
-};
-
-static const uint8_t PRN_PKT_CANCEL[] = {
-    PRN_LE(PRN_MAGIC), PRN_LE(PRN_CMD_BREAK),  PRN_LE(0), PRN_LE(0x01), PRN_LE(0)
 };
 
-static start_print_pkt_t PRN_PKT_START = {
-    .magic = PRN_MAGIC, .command = PRN_CMD_PRINT,
-    .length = 4, .print = TRUE,
-    .margins = 0, .palette = PRN_PALETTE_NORMAL, .exposure = PRN_EXPOSURE_DARK,
-    .crc = 0, .trail = 0
+struct prn_footer {
+    uint16_t crc;
+    uint8_t alive;
+    uint8_t status;
 };
 
-static uint16_t printer_status;
-static uint8_t printer_tile_num;
-
-static inline void gbprinter_set_print_params(uint8_t margins, uint8_t palette, uint8_t exposure) {
-    PRN_PKT_START.crc = ((PRN_CMD_PRINT + 0x04u + 0x01u)
-            + (PRN_PKT_START.margins = margins)
-            + (PRN_PKT_START.palette = palette)
-            + (PRN_PKT_START.exposure = exposure));
-}
-
-static uint8_t printer_send_receive(uint8_t b) {
+static uint8_t prn_send_receive(uint8_t b) {
     SB_REG = b;
-    SC_REG = START_TRANSFER;
-    while (SC_REG & 0x80);
+    SC_REG = SIOF_XFER_START | SIOF_CLOCK_INT;
+    while (SC_REG & SIOF_XFER_START);
     return SB_REG;
 }
 
-static uint8_t printer_send_byte(uint8_t b) {
-    return (uint8_t)(printer_status = ((printer_status << 8) | printer_send_receive(b)));
+static void prn_send_block(uint8_t *data, uint16_t length, uint16_t *crc) {
+    while (length-- > 0) {
+        uint8_t v = *data;
+        *crc += v;
+        *data = prn_send_receive(v);
+        data++;
+    }
 }
 
-static uint8_t printer_send_command(const uint8_t *command, uint8_t length) {
-    uint8_t index = 0;
-    while (index++ < length) printer_send_byte(*command++);
-    return ((uint8_t)(printer_status >> 8) == PRN_MAGIC_DETECT) ? (uint8_t)printer_status : PRN_STATUS_MASK_ERRORS;
-}
+static enum PRN_STATUS printer_send_command(enum PRN_CMDS cmd,
+                                            uint8_t *data, uint16_t length) {
+    static struct prn_header header;
+    static struct prn_footer footer;
+    uint16_t crc = 0;
 
-#define PRINTER_SEND_COMMAND(CMD) printer_send_command((const uint8_t *)&(CMD), sizeof(CMD))
+    header.magic = PRN_MAGIC;
+    header.command = cmd;
+    header.compression = 0;
+    header.length = data ? length : 0;
 
-static uint8_t printer_print_tile(const uint8_t *tiledata) {
-    static const uint8_t PRINT_TILE[] = { 0x88,0x33,0x04,0x00,0x80,0x02 };
-    static uint16_t printer_CRC;
-    if (printer_tile_num == 0) {
-        const uint8_t * data = PRINT_TILE;
-        for (uint8_t i = sizeof(PRINT_TILE); i != 0; i--) printer_send_receive(*data++);
-        printer_CRC = 0x04 + 0x80 + 0x02;
-    }
-    for(uint8_t i = 0x10; i != 0; i--, tiledata++) {
-        printer_CRC += *tiledata;
-        printer_send_receive(*tiledata);
-    }
-    if (++printer_tile_num == 40) {
-        printer_send_receive((uint8_t)printer_CRC);
-        printer_send_receive((uint8_t)(printer_CRC >> 8));
-        printer_send_receive(0x00);
-        printer_send_receive(0x00);
-        printer_CRC = printer_tile_num = 0;
-        return TRUE;
+    footer.crc = 0;
+    footer.alive = 0;
+    footer.status = 0;
+
+    prn_send_block((uint8_t *)&header, sizeof(struct prn_header), &crc);
+    if (data && (length > 0)) {
+        prn_send_block(data, length, &crc);
     }
-    return FALSE;
-}
 
-static inline void printer_init(void) {
-    printer_tile_num = 0;
-    PRINTER_SEND_COMMAND(PRN_PKT_INIT);
+    footer.crc = crc;
+    prn_send_block((uint8_t *)&footer, sizeof(struct prn_footer), &crc);
+
+    enum PRN_STATUS r = footer.status;
+    if (footer.alive != PRN_MAGIC_DETECT) {
+        r |= PRN_STATUS_NO_MAGIC;
+    }
+    return r;
 }
 
-uint8_t printer_check_cancel(void) {
+static uint8_t printer_check_cancel(void) {
     key_read();
     return key_pressed(J_B);
 }
 
-static uint8_t printer_wait(uint16_t timeout, uint8_t mask, uint8_t value) {
-    uint8_t error;
-    while (((error = PRINTER_SEND_COMMAND(PRN_PKT_STATUS)) & mask) != value) {
+static enum PRN_STATUS printer_wait(uint16_t timeout, uint8_t mask, uint8_t value) {
+    enum PRN_STATUS error;
+
+    while (1) {
+        error = printer_send_command(PRN_CMD_STATUS, NULL, 0);
+        if ((error & mask) == value) {
+            break;
+        }
+
         if (printer_check_cancel()) {
-            PRINTER_SEND_COMMAND(PRN_PKT_CANCEL);
+            printer_send_command(PRN_CMD_BREAK, NULL, 0);
             return PRN_STATUS_CANCELLED;
         }
-        if (timeout-- == 0) return PRN_STATUS_MASK_ERRORS;
-        if (error & PRN_STATUS_MASK_ERRORS) break;
+
+        if (timeout-- == 0) {
+            return PRN_STATUS_TIMEOUT;
+        }
+
+        if (error & PRN_STATUS_MASK_ERRORS) {
+            break;
+        }
+
         vsync();
     }
+
     return error;
 }
 
-uint8_t gbprinter_detect(uint8_t delay) BANKED {
-    printer_init();
-    uint8_t r = printer_wait(delay, PRN_STATUS_MASK_ANY, PRN_STATUS_OK);
+enum PRN_STATUS gbprinter_detect(void) BANKED {
+    printer_send_command(PRN_CMD_INIT, NULL, 0);
+    uint8_t r = printer_wait(PRN_DETECT_TIMEOUT, PRN_STATUS_MASK_ANY, PRN_STATUS_OK);
+
 #ifdef DEBUG
     EMU_printf("%s: %hu\n",  __func__, (uint8_t)r);
 #endif // DEBUG
     return r;
 }
 
-uint8_t gbprinter_print_image(const uint8_t *image_map, const uint8_t *image,
-                              int8_t pos_x, uint8_t width, uint8_t height,
-                              uint8_t done) BANKED {
-    uint8_t tile_data[16];
-    uint8_t rows = ((height + 1) >> 1) << 1;
-    uint8_t pkt_count = 0;
-
-    if ((rows >> 1) == 0) return PRN_STATUS_OK;
-
-    printer_tile_num = 0;
-
-    for (uint8_t y = 0; y < rows; y++) {
-        for (int16_t x = 0; x < PRN_TILE_WIDTH; x++) {
-#ifdef DEBUG
-            EMU_printf("%s: %hu %i\n",  __func__, (uint8_t)y, (int16_t)x);
-#endif // DEBUG
-
-            // overlay the picture tile if in range
-            if ((y < height) && (x >= pos_x) && (x < (pos_x + width))) {
-                uint8_t tile = image_map[(y * width) + (x - pos_x)];
-                memcpy(tile_data, image + ((uint16_t)tile << 4), sizeof(tile_data));
-            } else {
-                memset(tile_data, 0, sizeof(tile_data));
-            }
-
-            // print the resulting tile
-            if (printer_print_tile(tile_data)) {
-                pkt_count++;
-
-                if (printer_check_cancel()) {
-                    PRINTER_SEND_COMMAND(PRN_PKT_CANCEL);
-                    return PRN_STATUS_CANCELLED;
-                }
-            }
-
-            if (pkt_count == 9) {
-                pkt_count = 0;
-                PRINTER_SEND_COMMAND(PRN_PKT_EOF);
-
-                // setup margin if last packet
-                gbprinter_set_print_params((y == (rows - 1)) ? PRN_FINAL_MARGIN : PRN_NO_MARGINS,
-                                           PRN_PALETTE_NORMAL, PRN_EXPOSURE_DARK);
-
-                PRINTER_SEND_COMMAND(PRN_PKT_START);
-
-                // query printer status
-                uint8_t error = printer_wait(PRN_BUSY_TIMEOUT, PRN_STATUS_BUSY, PRN_STATUS_BUSY);
-                if (error & PRN_STATUS_MASK_ERRORS) {
-                    return error;
-                }
-
-                error = printer_wait(PRN_COMPLETION_TIMEOUT, PRN_STATUS_BUSY, 0);
-                if (error & PRN_STATUS_MASK_ERRORS) {
-                    return error;
-                }
-
-#ifdef REINIT_SEIKO
-                // reinit printer (required by Seiko?)
-                if (y < (rows - 1)) {
-                    PRINTER_SEND_COMMAND(PRN_PKT_INIT);
-                    error = printer_wait(PRN_SEIKO_RESET_TIMEOUT, PRN_STATUS_MASK_ANY, PRN_STATUS_OK);
-                    if (error) {
-                        return error;
-                    }
-                }
-#endif
-            }
-        }
-    }
-
-    if (pkt_count && done) {
-        PRINTER_SEND_COMMAND(PRN_PKT_EOF);
-
-        // setup printing if required
-        gbprinter_set_print_params(PRN_FINAL_MARGIN, PRN_PALETTE_NORMAL, PRN_EXPOSURE_DARK);
-        PRINTER_SEND_COMMAND(PRN_PKT_START);
-
-        // query printer status
-        uint8_t error = printer_wait(PRN_BUSY_TIMEOUT, PRN_STATUS_BUSY, PRN_STATUS_BUSY);
-        if (error & PRN_STATUS_MASK_ERRORS) {
-            return error;
-        }
-
-        error = printer_wait(PRN_COMPLETION_TIMEOUT, PRN_STATUS_BUSY, 0);
-        if (error & PRN_STATUS_MASK_ERRORS) {
-            return error;
-        }
-    }
-
-    return PRINTER_SEND_COMMAND(PRN_PKT_STATUS);
+static void win_str_helper(const char *s, uint8_t y_pos) {
+    static char line_buff[11];
+    strncpy(line_buff, s, 10);
+    line_buff[10] = '\0';
+    win_str_center(line_buff, y_pos, 0);
 }
 
-uint8_t gbprinter_screenshot(uint8_t win) BANKED {
-    static uint8_t map_buff[2 * DEVICE_SCREEN_WIDTH];
+enum PRN_STATUS gbprinter_screenshot(uint8_t win) BANKED {
     static uint8_t tile_buff[2 * DEVICE_SCREEN_WIDTH * 16];
+    static struct prn_config params;
+    enum PRN_STATUS r = PRN_STATUS_OK;
 
-    printer_init();
-    printer_status = 0x00;
-
-    uint8_t r = PRN_STATUS_OK;
+    printer_send_command(PRN_CMD_INIT, NULL, 0);
 
     for (int y = 0; y < DEVICE_SCREEN_HEIGHT; y += 2) {
         for (int y2 = 0; y2 < 2; y2++) {
             for (int x = 0; x < DEVICE_SCREEN_WIDTH; x++) {
                 uint8_t tile = win ? get_win_tile_xy(x, y + y2) : get_bkg_tile_xy(x, y + y2);
-                map_buff[x + (y2 * DEVICE_SCREEN_WIDTH)] = (x + (y2 * DEVICE_SCREEN_WIDTH));
                 win ? get_win_data(tile, 1, tile_buff + ((x + (y2 * DEVICE_SCREEN_WIDTH)) * 16))
                     : get_bkg_data(tile, 1, tile_buff + ((x + (y2 * DEVICE_SCREEN_WIDTH)) * 16));
             }
@@ -384,12 +192,54 @@ uint8_t gbprinter_screenshot(uint8_t win) BANKED {
                 : fill_bkg_rect(0, y + y2, DEVICE_SCREEN_WIDTH, 1, 0);
         }
 
-        r = gbprinter_print_image(map_buff, tile_buff, 0, DEVICE_SCREEN_WIDTH, 2,
-                                  (y == (DEVICE_SCREEN_HEIGHT - 2)) ? 1 : 0);
+        if (win) {
+            if (y == 0) {
+                win_str_helper("gb printer", 0);
+            } else if (y == 2) {
+                win_str_helper("transmit", 2);
+            } else if (y == 8) {
+                win_str_helper("in", 8);
+            } else if (y == 10) {
+                win_str_helper("progress", 10);
+            } else if (y == 16) {
+                win_str_helper("printing", 16);
+            }
+        }
+
+        r = printer_send_command(PRN_CMD_DATA, tile_buff, sizeof(tile_buff));
         if ((r & ~PRN_STATUS_UNTRAN) != PRN_STATUS_OK) {
-            break;
+            goto end;
+        }
+
+        if (printer_check_cancel()) {
+            printer_send_command(PRN_CMD_BREAK, NULL, 0);
+            r = PRN_STATUS_CANCELLED;
+            goto end;
         }
     }
 
+    printer_send_command(PRN_CMD_DATA, NULL, 0);
+
+    params.sheets = 1;
+    params.margins = PRN_FINAL_MARGIN;
+    params.palette = PRN_PALETTE_NORMAL;
+    params.exposure = PRN_EXPO_DARK;
+
+    printer_send_command(PRN_CMD_PRINT, (uint8_t *)&params, sizeof(struct prn_config));
+
+    r = printer_wait(PRN_BUSY_TIMEOUT, PRN_STATUS_BUSY, PRN_STATUS_BUSY);
+    if (r & PRN_STATUS_MASK_ERRORS) {
+        goto end;
+    }
+
+    r = printer_wait(PRN_PRINT_TIMEOUT, PRN_STATUS_BUSY, 0);
+    if (r & PRN_STATUS_MASK_ERRORS) {
+        goto end;
+    }
+
+end:
+#ifdef DEBUG
+    EMU_printf("%s: %hu\n",  __func__, (uint8_t)r);
+#endif // DEBUG
     return r;
 }

src/gbprinter.h

@@ -26,15 +26,29 @@
 #include <gbdk/platform.h>
 #include <stdint.h>
 
-#define PRN_STATUS_OK           0x00
-#define PRINTER_DETECT_TIMEOUT  10
-
-uint8_t gbprinter_detect(uint8_t delay) BANKED;
-uint8_t gbprinter_print_image(const uint8_t *image_map, const uint8_t *image,
-                              int8_t pos_x, uint8_t width, uint8_t height,
-                              uint8_t done) BANKED;
-uint8_t gbprinter_screenshot(uint8_t win) BANKED;
-uint8_t gbprinter_error(uint8_t status, char *buff);
+enum PRN_STATUS {
+    PRN_STATUS_LOWBAT      = 0x80, // battery too low
+    PRN_STATUS_ER2         = 0x40, // unspecified error
+    PRN_STATUS_ER1         = 0x20, // paper jam
+    PRN_STATUS_ER0         = 0x10, // packet error
+    PRN_STATUS_UNTRAN      = 0x08, // unprinted data in buffer
+    PRN_STATUS_FULL        = 0x04, // ready, triggered by DATA with len 0
+    PRN_STATUS_BUSY        = 0x02, // printer is printing
+    PRN_STATUS_CHECKSUM    = 0x01, // Checksum error
+    PRN_STATUS_OK          = 0x00,
+
+    PRN_STATUS_CANCELLED   = 0x100,
+    PRN_STATUS_TIMEOUT     = 0x200,
+    PRN_STATUS_NO_MAGIC    = 0x400,
+
+    PRN_STATUS_MASK_ERRORS = 0x7F0,
+    PRN_STATUS_MASK_ANY    = 0x7FF,
+};
+
+enum PRN_STATUS gbprinter_detect(void) BANKED;
+enum PRN_STATUS gbprinter_screenshot(uint8_t win) BANKED;
+
+uint8_t gbprinter_error(enum PRN_STATUS status, char *buff);
 
 BANKREF_EXTERN(gbprinter)
 BANKREF_EXTERN(gbprinter_error)

src/gbprinter_error.c

@@ -29,6 +29,8 @@
 
 BANKREF(gbprinter_error)
 
+#define ERROR_BITS 11
+
 static const char str_lowbat[] = "battery too low";
 static const char str_er2[] = "unknown error";
 static const char str_er1[] = "paper jam";
@@ -37,13 +39,17 @@ static const char str_untran[] = "unprocessed";
 static const char str_full[] = "data full";
 static const char str_busy[] = "printer busy";
 static const char str_sum[] = "checksum error";
+static const char str_cancel[] = "cancelled";
+static const char str_timeout[] = "timeout";
+static const char str_magic[] = "wrong magic byte";
 
-static const char * const error_strings[8] = {
+static const char * const error_strings[ERROR_BITS] = {
     str_sum, str_busy, str_full, str_untran,
-    str_er0, str_er1, str_er2, str_lowbat
+    str_er0, str_er1, str_er2, str_lowbat,
+    str_cancel, str_timeout, str_magic,
 };
 
-uint8_t gbprinter_error(uint8_t status, char *buff) NONBANKED {
+uint8_t gbprinter_error(enum PRN_STATUS status, char *buff) NONBANKED {
     if (status == PRN_STATUS_OK) {
         sprintf(buff, "ok");
         return 2;
@@ -51,7 +57,7 @@ uint8_t gbprinter_error(uint8_t status, char *buff) NONBANKED {
 
     uint8_t n = 0;
     START_ROM_BANK(BANK(gbprinter_error)) {
-        for (uint8_t i = 0; i < 8; i++) {
+        for (uint8_t i = 0; i < ERROR_BITS; i++) {
             if (status & (1 << i)) {
                 if (n != 0) {
                     buff[n++] = '\n';

src/main.c

@@ -89,7 +89,7 @@ static void highscore(uint8_t is_black) NONBANKED {
         if (key_pressed(J_A) || key_pressed(J_B)) {
             break;
         } else if (key_pressed(J_SELECT)) {
-            uint8_t status = gbprinter_detect(PRINTER_DETECT_TIMEOUT);
+            enum PRN_STATUS status = gbprinter_detect();
             if (status == PRN_STATUS_OK) {
                 win_score_clear(is_black, 1);
                 list_scores(is_black);

src/window.c

@@ -190,6 +190,12 @@ static void str_center(const char *s, uint8_t y_off, uint8_t is_black) {
     str(s, LINE_WIDTH - n, y_off, is_black);
 }
 
+void win_str_center(const char *s, uint8_t y_off, uint8_t is_black) NONBANKED {
+    START_ROM_BANK(BANK(window)) {
+        str_center(s, y_off, is_black);
+    } END_ROM_BANK
+}
+
 static void str_lines(const char *s, uint8_t y_off, uint8_t is_black) {
     if (strlen(s) > 10) {
         str(s, 0, y_off, is_black);
@@ -289,23 +295,23 @@ void win_score_draw(struct scores score, uint8_t off, uint8_t is_black) BANKED {
     number(is_black ? -score.score : score.score, 7, 4 + off * 3, is_black);
 }
 
-void win_score_print(uint8_t status) BANKED {
+void win_score_print(enum PRN_STATUS status) BANKED {
     static char buff[128];
 
     if (_cpu == CGB_TYPE) {
-        str_ascii("GB Printer", 0, 2, 0);
-        str_ascii("Score Printout", 0, 3, 0);
-        str_ascii("Result:", 0, 6, 0);
+        str_ascii("GB Printer", 0, 0, 0);
+        str_ascii("Score Printout", 0, 1, 0);
+        str_ascii("Result:", 0, 3, 0);
 
         if (status == PRN_STATUS_OK) {
-            str_ascii("success", 0, 7, 0);
+            str_ascii("success", 0, 8, 0);
         } else {
-            sprintf(buff, "error: 0x%hx", (uint8_t)status);
-            str_ascii(buff, 0, 7, 0);
-        }
+            sprintf(buff, "error: 0x%04x", (uint16_t)status);
+            str_ascii(buff, 0, 5, 0);
 
-        gbprinter_error(status, buff);
-        str_ascii_lines(buff, 9, 0);
+            gbprinter_error(status, buff);
+            str_ascii_lines(buff, 6, 0);
+        }
     } else {
         str("printout", 0, 4, 0);
         if (status == PRN_STATUS_OK) {

src/window.h

@@ -22,14 +22,16 @@
 
 #include <gbdk/platform.h>
 #include <stdint.h>
+
 #include "score.h"
+#include "gbprinter.h"
 
 void win_init(uint8_t is_splash);
 void win_splash_draw(int32_t lowest, int32_t highest) BANKED;
 void win_splash_mp(void) BANKED;
 void win_score_clear(uint8_t is_black, uint8_t no_bg) BANKED;
 void win_score_draw(struct scores score, uint8_t off, uint8_t is_black) BANKED;
-void win_score_print(uint8_t status) BANKED;
+void win_score_print(enum PRN_STATUS status) BANKED;
 void win_about(void) BANKED;
 void win_about_mp(void) BANKED;
 void win_conf(void) BANKED;
@@ -38,6 +40,8 @@ void win_name(int32_t score) BANKED;
 void win_name_draw(uint16_t name, uint8_t is_black, uint8_t pos) BANKED;
 uint8_t win_game_draw(int32_t score) BANKED;
 
+void win_str_center(const char *s, uint8_t y_off, uint8_t is_black);
+
 BANKREF_EXTERN(window)
 
 #endif // __WINDOW_H__