Browse Source

Be consistent in setting of the fan PWM.

Always set the FAN PWM value in check_axes_activity() and always use
the value of the active move if a move is active.
Kevin O'Connor 12 years ago
parent
commit
3f2f94ef28
2 changed files with 2 additions and 28 deletions
  1. 2
    22
      Marlin/planner.cpp
  2. 0
    6
      Marlin/ultralcd.cpp

+ 2
- 22
Marlin/planner.cpp View File

438
   unsigned char y_active = 0;  
438
   unsigned char y_active = 0;  
439
   unsigned char z_active = 0;
439
   unsigned char z_active = 0;
440
   unsigned char e_active = 0;
440
   unsigned char e_active = 0;
441
-  unsigned char fan_speed = 0;
442
-  unsigned char tail_fan_speed = 0;
441
+  unsigned char tail_fan_speed = fanSpeed;
443
   block_t *block;
442
   block_t *block;
444
 
443
 
445
   if(block_buffer_tail != block_buffer_head)
444
   if(block_buffer_tail != block_buffer_head)
453
       if(block->steps_y != 0) y_active++;
452
       if(block->steps_y != 0) y_active++;
454
       if(block->steps_z != 0) z_active++;
453
       if(block->steps_z != 0) z_active++;
455
       if(block->steps_e != 0) e_active++;
454
       if(block->steps_e != 0) e_active++;
456
-      if(block->fan_speed != 0) fan_speed++;
457
       block_index = (block_index+1) & (BLOCK_BUFFER_SIZE - 1);
455
       block_index = (block_index+1) & (BLOCK_BUFFER_SIZE - 1);
458
     }
456
     }
459
   }
457
   }
460
-  else
461
-  {
462
-    #if FAN_PIN > -1
463
-    #ifndef FAN_SOFT_PWM
464
-    if (fanSpeed != 0){
465
-      analogWrite(FAN_PIN,fanSpeed); // If buffer is empty use current fan speed
466
-    }
467
-    #endif
468
-	#endif
469
-  }
470
   if((DISABLE_X) && (x_active == 0)) disable_x();
458
   if((DISABLE_X) && (x_active == 0)) disable_x();
471
   if((DISABLE_Y) && (y_active == 0)) disable_y();
459
   if((DISABLE_Y) && (y_active == 0)) disable_y();
472
   if((DISABLE_Z) && (z_active == 0)) disable_z();
460
   if((DISABLE_Z) && (z_active == 0)) disable_z();
478
   }
466
   }
479
 #if FAN_PIN > -1
467
 #if FAN_PIN > -1
480
   #ifndef FAN_SOFT_PWM
468
   #ifndef FAN_SOFT_PWM
481
-  if((fanSpeed == 0) && (fan_speed ==0))
482
-  {
483
-    analogWrite(FAN_PIN, 0);
484
-  }
485
-
486
-  if (fanSpeed != 0 && tail_fan_speed !=0)
487
-  {
488
-    analogWrite(FAN_PIN,tail_fan_speed);
489
-  }
469
+  analogWrite(FAN_PIN,tail_fan_speed);
490
   #endif
470
   #endif
491
 #endif
471
 #endif
492
 #ifdef AUTOTEMP
472
 #ifdef AUTOTEMP

+ 0
- 6
Marlin/ultralcd.cpp View File

221
     setTargetHotend1(plaPreheatHotendTemp);
221
     setTargetHotend1(plaPreheatHotendTemp);
222
     setTargetHotend2(plaPreheatHotendTemp);
222
     setTargetHotend2(plaPreheatHotendTemp);
223
     setTargetBed(plaPreheatHPBTemp);
223
     setTargetBed(plaPreheatHPBTemp);
224
-#if FAN_PIN > -1
225
     fanSpeed = plaPreheatFanSpeed;
224
     fanSpeed = plaPreheatFanSpeed;
226
-    analogWrite(FAN_PIN,  fanSpeed);
227
-#endif
228
     lcd_return_to_status();
225
     lcd_return_to_status();
229
 }
226
 }
230
 
227
 
234
     setTargetHotend1(absPreheatHotendTemp);
231
     setTargetHotend1(absPreheatHotendTemp);
235
     setTargetHotend2(absPreheatHotendTemp);
232
     setTargetHotend2(absPreheatHotendTemp);
236
     setTargetBed(absPreheatHPBTemp);
233
     setTargetBed(absPreheatHPBTemp);
237
-#if FAN_PIN > -1
238
     fanSpeed = absPreheatFanSpeed;
234
     fanSpeed = absPreheatFanSpeed;
239
-    analogWrite(FAN_PIN,  fanSpeed);
240
-#endif
241
     lcd_return_to_status();
235
     lcd_return_to_status();
242
 }
236
 }
243
 
237
 

Loading…
Cancel
Save