Bladeren bron

More LVGL UI code reduction (#19879)

Victor Oliveira 4 jaren geleden
bovenliggende
commit
853d01de68
No account linked to committer's email address
48 gewijzigde bestanden met toevoegingen van 74 en 462 verwijderingen
  1. 1
    1
      Marlin/src/lcd/extui/lib/mks_ui/SPIFlashStorage.cpp
  2. 1
    11
      Marlin/src/lcd/extui/lib/mks_ui/draw_about.cpp
  3. 1
    10
      Marlin/src/lcd/extui/lib/mks_ui/draw_acceleration_settings.cpp
  4. 2
    11
      Marlin/src/lcd/extui/lib/mks_ui/draw_advance_settings.cpp
  5. 1
    11
      Marlin/src/lcd/extui/lib/mks_ui/draw_auto_level_offset_settings.cpp
  6. 1
    12
      Marlin/src/lcd/extui/lib/mks_ui/draw_baby_stepping.cpp
  7. 1
    12
      Marlin/src/lcd/extui/lib/mks_ui/draw_change_speed.cpp
  8. 1
    12
      Marlin/src/lcd/extui/lib/mks_ui/draw_dialog.cpp
  9. 1
    11
      Marlin/src/lcd/extui/lib/mks_ui/draw_eeprom_settings.cpp
  10. 1
    11
      Marlin/src/lcd/extui/lib/mks_ui/draw_encoder_settings.cpp
  11. 1
    8
      Marlin/src/lcd/extui/lib/mks_ui/draw_error_message.cpp
  12. 1
    12
      Marlin/src/lcd/extui/lib/mks_ui/draw_extrusion.cpp
  13. 1
    11
      Marlin/src/lcd/extui/lib/mks_ui/draw_fan.cpp
  14. 1
    12
      Marlin/src/lcd/extui/lib/mks_ui/draw_filament_change.cpp
  15. 1
    11
      Marlin/src/lcd/extui/lib/mks_ui/draw_filament_settings.cpp
  16. 1
    12
      Marlin/src/lcd/extui/lib/mks_ui/draw_home.cpp
  17. 1
    9
      Marlin/src/lcd/extui/lib/mks_ui/draw_homing_sensitivity_settings.cpp
  18. 1
    9
      Marlin/src/lcd/extui/lib/mks_ui/draw_jerk_settings.cpp
  19. 5
    14
      Marlin/src/lcd/extui/lib/mks_ui/draw_keyboard.cpp
  20. 1
    14
      Marlin/src/lcd/extui/lib/mks_ui/draw_language.cpp
  21. 2
    10
      Marlin/src/lcd/extui/lib/mks_ui/draw_level_settings.cpp
  22. 1
    11
      Marlin/src/lcd/extui/lib/mks_ui/draw_machine_para.cpp
  23. 1
    12
      Marlin/src/lcd/extui/lib/mks_ui/draw_machine_settings.cpp
  24. 1
    10
      Marlin/src/lcd/extui/lib/mks_ui/draw_manuaLevel.cpp
  25. 1
    8
      Marlin/src/lcd/extui/lib/mks_ui/draw_manual_level_pos_settings.cpp
  26. 1
    9
      Marlin/src/lcd/extui/lib/mks_ui/draw_max_feedrate_settings.cpp
  27. 2
    12
      Marlin/src/lcd/extui/lib/mks_ui/draw_motor_settings.cpp
  28. 1
    12
      Marlin/src/lcd/extui/lib/mks_ui/draw_move_motor.cpp
  29. 1
    11
      Marlin/src/lcd/extui/lib/mks_ui/draw_number_key.cpp
  30. 1
    11
      Marlin/src/lcd/extui/lib/mks_ui/draw_operation.cpp
  31. 1
    9
      Marlin/src/lcd/extui/lib/mks_ui/draw_pause_position.cpp
  32. 1
    11
      Marlin/src/lcd/extui/lib/mks_ui/draw_preHeat.cpp
  33. 1
    4
      Marlin/src/lcd/extui/lib/mks_ui/draw_print_file.cpp
  34. 1
    9
      Marlin/src/lcd/extui/lib/mks_ui/draw_printing.cpp
  35. 1
    6
      Marlin/src/lcd/extui/lib/mks_ui/draw_ready_print.cpp
  36. 1
    12
      Marlin/src/lcd/extui/lib/mks_ui/draw_set.cpp
  37. 1
    9
      Marlin/src/lcd/extui/lib/mks_ui/draw_step_settings.cpp
  38. 1
    9
      Marlin/src/lcd/extui/lib/mks_ui/draw_tmc_current_settings.cpp
  39. 1
    9
      Marlin/src/lcd/extui/lib/mks_ui/draw_tmc_step_mode_settings.cpp
  40. 1
    14
      Marlin/src/lcd/extui/lib/mks_ui/draw_tool.cpp
  41. 19
    1
      Marlin/src/lcd/extui/lib/mks_ui/draw_ui.cpp
  42. 1
    1
      Marlin/src/lcd/extui/lib/mks_ui/draw_ui.h
  43. 1
    11
      Marlin/src/lcd/extui/lib/mks_ui/draw_wifi.cpp
  44. 1
    11
      Marlin/src/lcd/extui/lib/mks_ui/draw_wifi_list.cpp
  45. 1
    11
      Marlin/src/lcd/extui/lib/mks_ui/draw_wifi_settings.cpp
  46. 1
    8
      Marlin/src/lcd/extui/lib/mks_ui/draw_wifi_tips.cpp
  47. 1
    1
      Marlin/src/lcd/extui/lib/mks_ui/wifiSerial.cpp
  48. 2
    6
      Marlin/src/lcd/extui/lib/mks_ui/wifi_upload.cpp

+ 1
- 1
Marlin/src/lcd/extui/lib/mks_ui/SPIFlashStorage.cpp Bestand weergeven

@@ -185,7 +185,7 @@ void SPIFlashStorage::loadPage(uint8_t* buffer) {
185 185
   // char fname[256];
186 186
   // snprintf(fname, sizeof(fname), "./pages/page-%03d.data", m_currentPage);
187 187
   // FILE *fp = fopen(fname, "rb");
188
-  // if (fp != nullptr) {
188
+  // if (fp) {
189 189
   //     fread(buffer, 1, SPI_FLASH_PageSize, fp);
190 190
   //     fclose(fp);
191 191
   // }

+ 1
- 11
Marlin/src/lcd/extui/lib/mks_ui/draw_about.cpp Bestand weergeven

@@ -49,17 +49,7 @@ static void event_handler(lv_obj_t *obj, lv_event_t event) {
49 49
 }
50 50
 
51 51
 void lv_draw_about(void) {
52
-  if (disp_state_stack._disp_state[disp_state_stack._disp_index] != ABOUT_UI) {
53
-    disp_state_stack._disp_index++;
54
-    disp_state_stack._disp_state[disp_state_stack._disp_index] = ABOUT_UI;
55
-  }
56
-  disp_state = ABOUT_UI;
57
-
58
-  scr = lv_screen_create();
59
-
60
-  (void)lv_label_create(scr, TITLE_XPOS, TITLE_YPOS, creat_title_text());
61
-
62
-  lv_refr_now(lv_refr_get_disp_refreshing());
52
+  scr = lv_screen_create(ABOUT_UI);
63 53
 
64 54
   // Create an Image button
65 55
   lv_obj_t *buttonBack = lv_imgbtn_create(scr, "F:/bmp_return.bin", BTN_X_PIXEL * 3 + INTERVAL_V * 4, BTN_Y_PIXEL + INTERVAL_H + titleHeight, event_handler, ID_A_RETURN);

+ 1
- 10
Marlin/src/lcd/extui/lib/mks_ui/draw_acceleration_settings.cpp Bestand weergeven

@@ -108,16 +108,7 @@ static void event_handler(lv_obj_t *obj, lv_event_t event) {
108 108
 }
109 109
 
110 110
 void lv_draw_acceleration_settings(void) {
111
-  if (disp_state_stack._disp_state[disp_state_stack._disp_index] != ACCELERATION_UI) {
112
-    disp_state_stack._disp_index++;
113
-    disp_state_stack._disp_state[disp_state_stack._disp_index] = ACCELERATION_UI;
114
-  }
115
-  disp_state = ACCELERATION_UI;
116
-
117
-  scr = lv_screen_create();
118
-
119
-  (void)lv_label_create(scr, TITLE_XPOS, TITLE_YPOS, machine_menu.AccelerationConfTitle);
120
-  lv_refr_now(lv_refr_get_disp_refreshing());
111
+  scr = lv_screen_create(ACCELERATION_UI, machine_menu.AccelerationConfTitle);
121 112
 
122 113
   if (uiCfg.para_ui_page != 1) {
123 114
     sprintf_P(public_buf_l, PSTR("%.1f"), planner.settings.acceleration);

+ 2
- 11
Marlin/src/lcd/extui/lib/mks_ui/draw_advance_settings.cpp Bestand weergeven

@@ -40,6 +40,7 @@ enum {
40 40
 };
41 41
 
42 42
 static void event_handler(lv_obj_t *obj, lv_event_t event) {
43
+  if (event != LV_EVENT_RELEASED) return;
43 44
   switch (obj->mks_obj_id) {
44 45
     case ID_ADVANCE_RETURN:
45 46
       lv_clear_advance_settings();
@@ -69,17 +70,7 @@ static void event_handler(lv_obj_t *obj, lv_event_t event) {
69 70
 }
70 71
 
71 72
 void lv_draw_advance_settings(void) {
72
-  if (disp_state_stack._disp_state[disp_state_stack._disp_index] != ADVANCED_UI) {
73
-    disp_state_stack._disp_index++;
74
-    disp_state_stack._disp_state[disp_state_stack._disp_index] = ADVANCED_UI;
75
-  }
76
-  disp_state = ADVANCED_UI;
77
-
78
-  scr = lv_screen_create();
79
-
80
-  (void)lv_label_create(scr, TITLE_XPOS, TITLE_YPOS, machine_menu.AdvancedConfTitle);
81
-
82
-  lv_refr_now(lv_refr_get_disp_refreshing());
73
+  scr = lv_screen_create(ADVANCED_UI, machine_menu.AdvancedConfTitle);
83 74
 
84 75
   int index = 0;
85 76
   lv_screen_menu_item(scr, machine_menu.PausePosition, PARA_UI_POS_X, PARA_UI_POS_Y, event_handler, ID_PAUSE_POS, index++);

+ 1
- 11
Marlin/src/lcd/extui/lib/mks_ui/draw_auto_level_offset_settings.cpp Bestand weergeven

@@ -65,17 +65,7 @@ static void event_handler(lv_obj_t *obj, lv_event_t event) {
65 65
 }
66 66
 
67 67
 void lv_draw_auto_level_offset_settings(void) {
68
-  if (disp_state_stack._disp_state[disp_state_stack._disp_index] != NOZZLE_PROBE_OFFSET_UI) {
69
-    disp_state_stack._disp_index++;
70
-    disp_state_stack._disp_state[disp_state_stack._disp_index] = NOZZLE_PROBE_OFFSET_UI;
71
-  }
72
-  disp_state = NOZZLE_PROBE_OFFSET_UI;
73
-
74
-  scr = lv_screen_create();
75
-
76
-  (void)lv_label_create(scr, TITLE_XPOS, TITLE_YPOS, machine_menu.OffsetConfTitle);
77
-
78
-  lv_refr_now(lv_refr_get_disp_refreshing());
68
+  scr = lv_screen_create(NOZZLE_PROBE_OFFSET_UI, machine_menu.OffsetConfTitle);
79 69
 
80 70
   sprintf_P(public_buf_l, PSTR("%.1f"), TERN(HAS_PROBE_XY_OFFSET, probe.offset.x, 0));
81 71
   lv_screen_menu_item_1_edit(scr, machine_menu.Xoffset, PARA_UI_POS_X, PARA_UI_POS_Y, event_handler, ID_OFFSET_X, 0, public_buf_l);

+ 1
- 12
Marlin/src/lcd/extui/lib/mks_ui/draw_baby_stepping.cpp Bestand weergeven

@@ -112,18 +112,7 @@ static void event_handler(lv_obj_t *obj, lv_event_t event) {
112 112
 }
113 113
 
114 114
 void lv_draw_baby_stepping(void) {
115
-  if (disp_state_stack._disp_state[disp_state_stack._disp_index] != BABY_STEP_UI) {
116
-    disp_state_stack._disp_index++;
117
-    disp_state_stack._disp_state[disp_state_stack._disp_index] = BABY_STEP_UI;
118
-  }
119
-  disp_state = BABY_STEP_UI;
120
-
121
-  scr = lv_screen_create();
122
-
123
-  (void)lv_label_create(scr, TITLE_XPOS, TITLE_YPOS, creat_title_text());
124
-
125
-  lv_refr_now(lv_refr_get_disp_refreshing());
126
-
115
+  scr = lv_screen_create(BABY_STEP_UI);
127 116
   lv_big_button_create(scr, "F:/bmp_xAdd.bin", move_menu.x_add, INTERVAL_V, titleHeight, event_handler, ID_BABY_STEP_X_P);
128 117
   lv_big_button_create(scr, "F:/bmp_xDec.bin", move_menu.x_dec, INTERVAL_V, BTN_Y_PIXEL + INTERVAL_H + titleHeight, event_handler, ID_BABY_STEP_X_N);
129 118
   lv_big_button_create(scr, "F:/bmp_yAdd.bin", move_menu.y_add, BTN_X_PIXEL + INTERVAL_V * 2, titleHeight, event_handler, ID_BABY_STEP_Y_P);

+ 1
- 12
Marlin/src/lcd/extui/lib/mks_ui/draw_change_speed.cpp Bestand weergeven

@@ -126,18 +126,7 @@ static void event_handler(lv_obj_t *obj, lv_event_t event) {
126 126
 }
127 127
 
128 128
 void lv_draw_change_speed(void) {
129
-  if (disp_state_stack._disp_state[disp_state_stack._disp_index] != CHANGE_SPEED_UI) {
130
-    disp_state_stack._disp_index++;
131
-    disp_state_stack._disp_state[disp_state_stack._disp_index] = CHANGE_SPEED_UI;
132
-  }
133
-  disp_state = CHANGE_SPEED_UI;
134
-
135
-  scr = lv_screen_create();
136
-
137
-  (void)lv_label_create(scr, TITLE_XPOS, TITLE_YPOS, creat_title_text());
138
-
139
-  lv_refr_now(lv_refr_get_disp_refreshing());
140
-
129
+  scr = lv_screen_create(CHANGE_SPEED_UI);
141 130
   // Create an Image button
142 131
   lv_big_button_create(scr, "F:/bmp_Add.bin", speed_menu.add, INTERVAL_V, titleHeight, event_handler, ID_C_ADD);
143 132
   lv_big_button_create(scr, "F:/bmp_Dec.bin", speed_menu.dec, BTN_X_PIXEL * 3 + INTERVAL_V * 4, titleHeight, event_handler, ID_C_DEC);

+ 1
- 12
Marlin/src/lcd/extui/lib/mks_ui/draw_dialog.cpp Bestand weergeven

@@ -211,19 +211,8 @@ static void btn_cancel_event_cb(lv_obj_t *btn, lv_event_t event) {
211 211
 
212 212
 void lv_draw_dialog(uint8_t type) {
213 213
   lv_obj_t *btnOk = nullptr, *btnCancel = nullptr;
214
-  if (disp_state_stack._disp_state[disp_state_stack._disp_index] != DIALOG_UI) {
215
-    disp_state_stack._disp_index++;
216
-    disp_state_stack._disp_state[disp_state_stack._disp_index] = DIALOG_UI;
217
-  }
218
-  disp_state = DIALOG_UI;
219
-
220 214
   uiCfg.dialogType = type;
221
-
222
-  scr = lv_screen_create();
223
-
224
-  (void)lv_label_create(scr, TITLE_XPOS, TITLE_YPOS, creat_title_text());
225
-
226
-  lv_refr_now(lv_refr_get_disp_refreshing());
215
+  scr = lv_screen_create(DIALOG_UI);
227 216
 
228 217
   lv_obj_t *labelDialog = lv_label_create_empty(scr);
229 218
 

+ 1
- 11
Marlin/src/lcd/extui/lib/mks_ui/draw_eeprom_settings.cpp Bestand weergeven

@@ -66,17 +66,7 @@ static void event_handler(lv_obj_t *obj, lv_event_t event) {
66 66
 }
67 67
 
68 68
 void lv_draw_eeprom_settings(void) {
69
-  if (disp_state_stack._disp_state[disp_state_stack._disp_index] != EEPROM_SETTINGS_UI) {
70
-    disp_state_stack._disp_index++;
71
-    disp_state_stack._disp_state[disp_state_stack._disp_index] = EEPROM_SETTINGS_UI;
72
-  }
73
-  disp_state = EEPROM_SETTINGS_UI;
74
-
75
-  scr = lv_screen_create();
76
-
77
-  (void)lv_label_create(scr, TITLE_XPOS, TITLE_YPOS, creat_title_text());
78
-  lv_refr_now(lv_refr_get_disp_refreshing());
79
-
69
+  scr = lv_screen_create(EEPROM_SETTINGS_UI);
80 70
   lv_screen_menu_item(scr, eeprom_menu.revert, PARA_UI_POS_X, PARA_UI_POS_Y, event_handler, ID_EEPROM_REVERT, 0);
81 71
   lv_screen_menu_item(scr, eeprom_menu.store, PARA_UI_POS_X, PARA_UI_POS_Y * 2, event_handler, ID_EEPROM_STORE, 1);
82 72
   lv_big_button_create(scr, "F:/bmp_back70x40.bin", common_menu.text_back, PARA_UI_BACL_POS_X, PARA_UI_BACL_POS_Y, event_handler, ID_EEPROM_RETURN, true);

+ 1
- 11
Marlin/src/lcd/extui/lib/mks_ui/draw_encoder_settings.cpp Bestand weergeven

@@ -55,18 +55,8 @@ static void event_handler(lv_obj_t *obj, lv_event_t event) {
55 55
 }
56 56
 
57 57
 void lv_draw_encoder_settings(void) {
58
-  if (disp_state_stack._disp_state[disp_state_stack._disp_index] != ENCODER_SETTINGS_UI) {
59
-    disp_state_stack._disp_index++;
60
-    disp_state_stack._disp_state[disp_state_stack._disp_index] = ENCODER_SETTINGS_UI;
61
-  }
62
-  disp_state = ENCODER_SETTINGS_UI;
63
-
64
-  scr = lv_screen_create();
65
-  (void)lv_label_create(scr, TITLE_XPOS, TITLE_YPOS, machine_menu.EncoderConfTitle);
66
-  lv_refr_now(lv_refr_get_disp_refreshing());
67
-
58
+  scr = lv_screen_create(ENCODER_SETTINGS_UI, machine_menu.EncoderConfTitle);
68 59
   buttonEncoderState = lv_screen_menu_item_onoff(scr, machine_menu.EncoderConfText, PARA_UI_POS_X, PARA_UI_POS_Y, event_handler, ID_ENCODER_STATE, 0, gCfgItems.encoder_enable);
69
-
70 60
   lv_big_button_create(scr, "F:/bmp_back70x40.bin", common_menu.text_back, PARA_UI_BACL_POS_X, PARA_UI_BACL_POS_Y, event_handler, ID_ENCODER_RETURN, true);
71 61
 }
72 62
 

+ 1
- 8
Marlin/src/lcd/extui/lib/mks_ui/draw_error_message.cpp Bestand weergeven

@@ -41,15 +41,8 @@ static lv_obj_t *scr;
41 41
 void lv_draw_error_message(PGM_P const msg) {
42 42
   #if 0
43 43
     static lv_obj_t *message = nullptr, *kill_message = nullptr, *reset_tips = nullptr;
44
-    if (disp_state_stack._disp_state[disp_state_stack._disp_index] != ERROR_MESSAGE_UI) {
45
-      disp_state_stack._disp_index++;
46
-      disp_state_stack._disp_state[disp_state_stack._disp_index] = ERROR_MESSAGE_UI;
47
-    }
48
-    disp_state = ERROR_MESSAGE_UI;
49
-
50
-    scr = lv_screen_create();
51 44
 
52
-    lv_refr_now(lv_refr_get_disp_refreshing());
45
+    scr = lv_screen_create(ERROR_MESSAGE_UI, "");
53 46
 
54 47
     if (msg) {
55 48
       message = lv_label_create(scr, msg);

+ 1
- 12
Marlin/src/lcd/extui/lib/mks_ui/draw_extrusion.cpp Bestand weergeven

@@ -122,18 +122,7 @@ static void event_handler(lv_obj_t *obj, lv_event_t event) {
122 122
 }
123 123
 
124 124
 void lv_draw_extrusion(void) {
125
-  if (disp_state_stack._disp_state[disp_state_stack._disp_index] != EXTRUSION_UI) {
126
-    disp_state_stack._disp_index++;
127
-    disp_state_stack._disp_state[disp_state_stack._disp_index] = EXTRUSION_UI;
128
-  }
129
-  disp_state = EXTRUSION_UI;
130
-
131
-  scr = lv_screen_create();
132
-
133
-  (void)lv_label_create(scr, TITLE_XPOS, TITLE_YPOS, creat_title_text());
134
-
135
-  lv_refr_now(lv_refr_get_disp_refreshing());
136
-
125
+  scr = lv_screen_create(EXTRUSION_UI);
137 126
   // Create image buttons
138 127
   lv_obj_t *buttonAdd = lv_big_button_create(scr, "F:/bmp_in.bin", extrude_menu.in, INTERVAL_V, titleHeight, event_handler, ID_E_ADD);
139 128
   lv_obj_clear_protect(buttonAdd, LV_PROTECT_FOLLOW);

+ 1
- 11
Marlin/src/lcd/extui/lib/mks_ui/draw_fan.cpp Bestand weergeven

@@ -89,18 +89,8 @@ void lv_draw_fan(void) {
89 89
   #if HAS_FAN
90 90
     fanSpeed = thermalManager.fan_speed[0];
91 91
   #endif
92
-  if (disp_state_stack._disp_state[disp_state_stack._disp_index] != FAN_UI) {
93
-    disp_state_stack._disp_index++;
94
-    disp_state_stack._disp_state[disp_state_stack._disp_index] = FAN_UI;
95
-  }
96
-  disp_state = FAN_UI;
97
-
98
-  scr = lv_screen_create();
99
-
100
-  (void)lv_label_create(scr, TITLE_XPOS, TITLE_YPOS, creat_title_text());
101
-
102
-  lv_refr_now(lv_refr_get_disp_refreshing());
103 92
 
93
+  scr = lv_screen_create(FAN_UI);
104 94
   // Create an Image button
105 95
   buttonAdd  = lv_big_button_create(scr, "F:/bmp_Add.bin", fan_menu.add, INTERVAL_V, titleHeight, event_handler, ID_F_ADD);
106 96
   lv_obj_clear_protect(buttonAdd, LV_PROTECT_FOLLOW);

+ 1
- 12
Marlin/src/lcd/extui/lib/mks_ui/draw_filament_change.cpp Bestand weergeven

@@ -112,18 +112,7 @@ static void event_handler(lv_obj_t *obj, lv_event_t event) {
112 112
 }
113 113
 
114 114
 void lv_draw_filament_change(void) {
115
-  if (disp_state_stack._disp_state[disp_state_stack._disp_index] != FILAMENTCHANGE_UI) {
116
-    disp_state_stack._disp_index++;
117
-    disp_state_stack._disp_state[disp_state_stack._disp_index] = FILAMENTCHANGE_UI;
118
-  }
119
-  disp_state = FILAMENTCHANGE_UI;
120
-
121
-  scr = lv_screen_create();
122
-
123
-  (void)lv_label_create(scr, TITLE_XPOS, TITLE_YPOS, creat_title_text());
124
-
125
-  lv_refr_now(lv_refr_get_disp_refreshing());
126
-
115
+  scr = lv_screen_create(FILAMENTCHANGE_UI);
127 116
   // Create an Image button
128 117
   lv_obj_t *buttonIn = lv_big_button_create(scr, "F:/bmp_in.bin", filament_menu.in, INTERVAL_V, titleHeight, event_handler, ID_FILAMNT_IN);
129 118
   lv_obj_clear_protect(buttonIn, LV_PROTECT_FOLLOW);

+ 1
- 11
Marlin/src/lcd/extui/lib/mks_ui/draw_filament_settings.cpp Bestand weergeven

@@ -89,17 +89,7 @@ static void event_handler(lv_obj_t *obj, lv_event_t event) {
89 89
 }
90 90
 
91 91
 void lv_draw_filament_settings(void) {
92
-  if (disp_state_stack._disp_state[disp_state_stack._disp_index] != FILAMENT_SETTINGS_UI) {
93
-    disp_state_stack._disp_index++;
94
-    disp_state_stack._disp_state[disp_state_stack._disp_index] = FILAMENT_SETTINGS_UI;
95
-  }
96
-  disp_state = FILAMENT_SETTINGS_UI;
97
-
98
-  scr = lv_screen_create();
99
-
100
-  (void)lv_label_create(scr, TITLE_XPOS, TITLE_YPOS, machine_menu.FilamentConfTitle);
101
-
102
-  lv_refr_now(lv_refr_get_disp_refreshing());
92
+  scr = lv_screen_create(FILAMENT_SETTINGS_UI, machine_menu.FilamentConfTitle);
103 93
 
104 94
   if (uiCfg.para_ui_page != 1) {
105 95
     sprintf_P(public_buf_l, PSTR("%d"), gCfgItems.filamentchange_load_length);

+ 1
- 12
Marlin/src/lcd/extui/lib/mks_ui/draw_home.cpp Bestand weergeven

@@ -77,18 +77,7 @@ static void event_handler(lv_obj_t *obj, lv_event_t event) {
77 77
 }
78 78
 
79 79
 void lv_draw_home(void) {
80
-  if (disp_state_stack._disp_state[disp_state_stack._disp_index] != ZERO_UI) {
81
-    disp_state_stack._disp_index++;
82
-    disp_state_stack._disp_state[disp_state_stack._disp_index] = ZERO_UI;
83
-  }
84
-  disp_state = ZERO_UI;
85
-
86
-  scr = lv_screen_create();
87
-
88
-  (void)lv_label_create(scr, TITLE_XPOS, TITLE_YPOS, creat_title_text());
89
-
90
-  lv_refr_now(lv_refr_get_disp_refreshing());
91
-
80
+  scr = lv_screen_create(ZERO_UI);
92 81
   lv_big_button_create(scr, "F:/bmp_zeroAll.bin", home_menu.home_all, INTERVAL_V, titleHeight, event_handler, ID_H_ALL);
93 82
   lv_big_button_create(scr, "F:/bmp_zeroX.bin", home_menu.home_x, BTN_X_PIXEL + INTERVAL_V * 2, titleHeight, event_handler, ID_H_X);
94 83
   lv_big_button_create(scr, "F:/bmp_zeroY.bin", home_menu.home_y, BTN_X_PIXEL * 2 + INTERVAL_V * 3, titleHeight, event_handler, ID_H_Y);

+ 1
- 9
Marlin/src/lcd/extui/lib/mks_ui/draw_homing_sensitivity_settings.cpp Bestand weergeven

@@ -75,15 +75,7 @@ static void event_handler(lv_obj_t *obj, lv_event_t event) {
75 75
 }
76 76
 
77 77
 void lv_draw_homing_sensitivity_settings(void) {
78
-  if (disp_state_stack._disp_state[disp_state_stack._disp_index] != HOMING_SENSITIVITY_UI) {
79
-    disp_state_stack._disp_index++;
80
-    disp_state_stack._disp_state[disp_state_stack._disp_index] = HOMING_SENSITIVITY_UI;
81
-  }
82
-  disp_state = HOMING_SENSITIVITY_UI;
83
-
84
-  scr = lv_screen_create();
85
-  (void)lv_label_create(scr, TITLE_XPOS, TITLE_YPOS, machine_menu.HomingSensitivityConfTitle);
86
-  lv_refr_now(lv_refr_get_disp_refreshing());
78
+  scr = lv_screen_create(HOMING_SENSITIVITY_UI, machine_menu.HomingSensitivityConfTitle);
87 79
 
88 80
   sprintf_P(public_buf_l, PSTR("%d"), TERN(X_SENSORLESS, stepperX.homing_threshold(), 0));
89 81
   lv_screen_menu_item_1_edit(scr, machine_menu.X_Sensitivity, PARA_UI_POS_X, PARA_UI_POS_Y, event_handler, ID_SENSITIVITY_X, 0, public_buf_l);

+ 1
- 9
Marlin/src/lcd/extui/lib/mks_ui/draw_jerk_settings.cpp Bestand weergeven

@@ -71,15 +71,7 @@ static void event_handler(lv_obj_t *obj, lv_event_t event) {
71 71
 }
72 72
 
73 73
 void lv_draw_jerk_settings(void) {
74
-  if (disp_state_stack._disp_state[disp_state_stack._disp_index] != JERK_UI) {
75
-    disp_state_stack._disp_index++;
76
-    disp_state_stack._disp_state[disp_state_stack._disp_index] = JERK_UI;
77
-  }
78
-  disp_state = JERK_UI;
79
-
80
-  scr = lv_screen_create();
81
-  (void)lv_label_create(scr, TITLE_XPOS, TITLE_YPOS, machine_menu.JerkConfTitle);
82
-  lv_refr_now(lv_refr_get_disp_refreshing());
74
+  scr = lv_screen_create(JERK_UI, machine_menu.JerkConfTitle);
83 75
 
84 76
   sprintf_P(public_buf_l, PSTR("%.1f"), planner.max_jerk[X_AXIS]);
85 77
   lv_screen_menu_item_1_edit(scr, machine_menu.X_Jerk, PARA_UI_POS_X, PARA_UI_POS_Y, event_handler, ID_JERK_X, 0, public_buf_l);

+ 5
- 14
Marlin/src/lcd/extui/lib/mks_ui/draw_keyboard.cpp Bestand weergeven

@@ -84,7 +84,7 @@ static void lv_kb_event_cb(lv_obj_t *kb, lv_event_t event) {
84 84
   if (lv_btnm_get_btn_ctrl(kb, btn_id, LV_BTNM_CTRL_NO_REPEAT) && event == LV_EVENT_LONG_PRESSED_REPEAT) return;
85 85
 
86 86
   const char * txt = lv_btnm_get_active_btn_text(kb);
87
-  if (txt == nullptr) return;
87
+  if (!txt) return;
88 88
 
89 89
   // Do the corresponding action according to the text of the button
90 90
   if (strcmp(txt, "abc") == 0) {
@@ -169,14 +169,13 @@ static void lv_kb_event_cb(lv_obj_t *kb, lv_event_t event) {
169 169
         default: break;
170 170
       }
171 171
     }
172
-    else {
173
-      lv_kb_set_ta(kb, nullptr); /*De-assign the text area to hide it cursor if needed*/
174
-    }
172
+    else
173
+      lv_kb_set_ta(kb, nullptr); // De-assign the text area to hide it cursor if needed
175 174
   return;
176 175
   }
177 176
 
178 177
   /*Add the characters to the text area if set*/
179
-  if (ext->ta == nullptr) return;
178
+  if (!ext->ta) return;
180 179
 
181 180
   if (strcmp(txt, "Enter") == 0 || strcmp(txt, LV_SYMBOL_NEW_LINE) == 0)
182 181
     lv_ta_add_char(ext->ta, '\n');
@@ -213,15 +212,7 @@ static void lv_kb_event_cb(lv_obj_t *kb, lv_event_t event) {
213 212
 }
214 213
 
215 214
 void lv_draw_keyboard() {
216
-  if (disp_state_stack._disp_state[disp_state_stack._disp_index] != KEY_BOARD_UI) {
217
-    disp_state_stack._disp_index++;
218
-    disp_state_stack._disp_state[disp_state_stack._disp_index] = KEY_BOARD_UI;
219
-  }
220
-  disp_state = KEY_BOARD_UI;
221
-
222
-  scr = lv_screen_create();
223
-
224
-  lv_refr_now(lv_refr_get_disp_refreshing());
215
+  scr = lv_screen_create(KEY_BOARD_UI, "");
225 216
 
226 217
   /*Create styles for the keyboard*/
227 218
   static lv_style_t rel_style, pr_style;

+ 1
- 14
Marlin/src/lcd/extui/lib/mks_ui/draw_language.cpp Bestand weergeven

@@ -188,19 +188,7 @@ static void disp_language(uint8_t language, uint8_t state) {
188 188
 }
189 189
 
190 190
 void lv_draw_language(void) {
191
-
192
-  if (disp_state_stack._disp_state[disp_state_stack._disp_index] != LANGUAGE_UI) {
193
-    disp_state_stack._disp_index++;
194
-    disp_state_stack._disp_state[disp_state_stack._disp_index] = LANGUAGE_UI;
195
-  }
196
-  disp_state = LANGUAGE_UI;
197
-
198
-  scr = lv_screen_create();
199
-
200
-  (void)lv_label_create(scr, TITLE_XPOS, TITLE_YPOS, creat_title_text());
201
-
202
-  lv_refr_now(lv_refr_get_disp_refreshing());
203
-
191
+  scr = lv_screen_create(LANGUAGE_UI);
204 192
   // Create image buttons
205 193
   buttonCN = lv_big_button_create(scr, "F:/bmp_simplified_cn.bin", language_menu.chinese_s, INTERVAL_V, titleHeight, event_handler, ID_CN);
206 194
   lv_obj_clear_protect(buttonCN, LV_PROTECT_FOLLOW);
@@ -211,7 +199,6 @@ void lv_draw_language(void) {
211 199
   buttonFR = lv_big_button_create(scr, "F:/bmp_french.bin", language_menu.french, BTN_X_PIXEL + INTERVAL_V * 2, BTN_Y_PIXEL + INTERVAL_H + titleHeight, event_handler, ID_FR);
212 200
   buttonIT = lv_big_button_create(scr, "F:/bmp_italy.bin", language_menu.italy, BTN_X_PIXEL * 2 + INTERVAL_V * 3, BTN_Y_PIXEL + INTERVAL_H + titleHeight, event_handler, ID_IT);
213 201
   lv_big_button_create(scr, "F:/bmp_return.bin", common_menu.text_back, BTN_X_PIXEL * 3 + INTERVAL_V * 4, BTN_Y_PIXEL + INTERVAL_H + titleHeight, event_handler, ID_L_RETURN);
214
-
215 202
   disp_language(gCfgItems.language, SELECTED);
216 203
 }
217 204
 

+ 2
- 10
Marlin/src/lcd/extui/lib/mks_ui/draw_level_settings.cpp Bestand weergeven

@@ -39,6 +39,7 @@ enum {
39 39
 };
40 40
 
41 41
 static void event_handler(lv_obj_t *obj, lv_event_t event) {
42
+  if (event != LV_EVENT_RELEASED) return;
42 43
   switch (obj->mks_obj_id) {
43 44
     case ID_LEVEL_RETURN:
44 45
       lv_clear_level_settings();
@@ -63,16 +64,7 @@ static void event_handler(lv_obj_t *obj, lv_event_t event) {
63 64
 }
64 65
 
65 66
 void lv_draw_level_settings(void) {
66
-  if (disp_state_stack._disp_state[disp_state_stack._disp_index] != LEVELING_PARA_UI) {
67
-    disp_state_stack._disp_index++;
68
-    disp_state_stack._disp_state[disp_state_stack._disp_index] = LEVELING_PARA_UI;
69
-  }
70
-  disp_state = LEVELING_PARA_UI;
71
-
72
-  scr = lv_screen_create();
73
-  (void)lv_label_create(scr, TITLE_XPOS, TITLE_YPOS, machine_menu.LevelingParaConfTitle);
74
-  lv_refr_now(lv_refr_get_disp_refreshing());
75
-
67
+  scr = lv_screen_create(LEVELING_PARA_UI, machine_menu.LevelingParaConfTitle);
76 68
   lv_screen_menu_item(scr, machine_menu.LevelingManuPosConf, PARA_UI_POS_X, PARA_UI_POS_Y, event_handler, ID_LEVEL_POSITION, 0);
77 69
   lv_screen_menu_item(scr, machine_menu.LevelingAutoCommandConf, PARA_UI_POS_X, PARA_UI_POS_Y * 2, event_handler, ID_LEVEL_COMMAND, 1);
78 70
   #if HAS_BED_PROBE

+ 1
- 11
Marlin/src/lcd/extui/lib/mks_ui/draw_machine_para.cpp Bestand weergeven

@@ -66,17 +66,7 @@ static void event_handler(lv_obj_t *obj, lv_event_t event) {
66 66
 }
67 67
 
68 68
 void lv_draw_machine_para(void) {
69
-  if (disp_state_stack._disp_state[disp_state_stack._disp_index] != MACHINE_PARA_UI) {
70
-    disp_state_stack._disp_index++;
71
-    disp_state_stack._disp_state[disp_state_stack._disp_index] = MACHINE_PARA_UI;
72
-  }
73
-  disp_state = MACHINE_PARA_UI;
74
-
75
-  scr = lv_screen_create();
76
-
77
-  (void)lv_label_create(scr, TITLE_XPOS, TITLE_YPOS, creat_title_text());
78
-  lv_refr_now(lv_refr_get_disp_refreshing());
79
-
69
+  scr = lv_screen_create(MACHINE_PARA_UI);
80 70
   lv_screen_menu_item(scr, MachinePara_menu.MachineSetting, PARA_UI_POS_X, PARA_UI_POS_Y, event_handler, ID_PARA_MACHINE, 0);
81 71
   lv_screen_menu_item(scr, MachinePara_menu.MotorSetting, PARA_UI_POS_X, PARA_UI_POS_Y * 2, event_handler, ID_PARA_MOTOR, 1);
82 72
   lv_screen_menu_item(scr, MachinePara_menu.leveling, PARA_UI_POS_X, PARA_UI_POS_Y * 3, event_handler, ID_PARA_LEVEL, 2);

+ 1
- 12
Marlin/src/lcd/extui/lib/mks_ui/draw_machine_settings.cpp Bestand weergeven

@@ -63,18 +63,7 @@ static void event_handler(lv_obj_t *obj, lv_event_t event) {
63 63
 }
64 64
 
65 65
 void lv_draw_machine_settings(void) {
66
-  if (disp_state_stack._disp_state[disp_state_stack._disp_index] != MACHINE_SETTINGS_UI) {
67
-    disp_state_stack._disp_index++;
68
-    disp_state_stack._disp_state[disp_state_stack._disp_index] = MACHINE_SETTINGS_UI;
69
-  }
70
-  disp_state = MACHINE_SETTINGS_UI;
71
-
72
-  scr = lv_screen_create();
73
-
74
-  (void)lv_label_create(scr, TITLE_XPOS, TITLE_YPOS, machine_menu.MachineConfigTitle);
75
-
76
-  lv_refr_now(lv_refr_get_disp_refreshing());
77
-
66
+  scr = lv_screen_create(MACHINE_SETTINGS_UI, machine_menu.MachineConfigTitle);
78 67
   lv_screen_menu_item(scr, machine_menu.AccelerationConf, PARA_UI_POS_X, PARA_UI_POS_Y, event_handler, ID_MACHINE_ACCELERATION, 0);
79 68
   lv_screen_menu_item(scr, machine_menu.MaxFeedRateConf, PARA_UI_POS_X, PARA_UI_POS_Y * 2, event_handler, ID_MACHINE_FEEDRATE, 1);
80 69
   #if HAS_CLASSIC_JERK

+ 1
- 10
Marlin/src/lcd/extui/lib/mks_ui/draw_manuaLevel.cpp Bestand weergeven

@@ -118,16 +118,7 @@ static void event_handler(lv_obj_t *obj, lv_event_t event) {
118 118
 }
119 119
 
120 120
 void lv_draw_manualLevel(void) {
121
-  if (disp_state_stack._disp_state[disp_state_stack._disp_index] != LEVELING_UI) {
122
-    disp_state_stack._disp_index++;
123
-    disp_state_stack._disp_state[disp_state_stack._disp_index] = LEVELING_UI;
124
-  }
125
-  disp_state = LEVELING_UI;
126
-
127
-  scr = lv_screen_create();
128
-  (void)lv_label_create(scr, TITLE_XPOS, TITLE_YPOS, creat_title_text());
129
-  lv_refr_now(lv_refr_get_disp_refreshing());
130
-
121
+  scr = lv_screen_create(LEVELING_UI);
131 122
   // Create an Image button
132 123
   lv_obj_t *buttonPoint1 = lv_big_button_create(scr, "F:/bmp_leveling1.bin", leveling_menu.position1, INTERVAL_V, titleHeight, event_handler, ID_M_POINT1);
133 124
   lv_obj_clear_protect(buttonPoint1, LV_PROTECT_FOLLOW);

+ 1
- 8
Marlin/src/lcd/extui/lib/mks_ui/draw_manual_level_pos_settings.cpp Bestand weergeven

@@ -121,15 +121,8 @@ static void event_handler(lv_obj_t *obj, lv_event_t event) {
121 121
 
122 122
 void lv_draw_manual_level_pos_settings(void) {
123 123
   char buf2[50];
124
-  if (disp_state_stack._disp_state[disp_state_stack._disp_index] != MANUAL_LEVELING_POSIGION_UI) {
125
-    disp_state_stack._disp_index++;
126
-    disp_state_stack._disp_state[disp_state_stack._disp_index] = MANUAL_LEVELING_POSIGION_UI;
127
-  }
128
-  disp_state = MANUAL_LEVELING_POSIGION_UI;
129 124
 
130
-  scr = lv_screen_create();
131
-  (void)lv_label_create(scr, TITLE_XPOS, TITLE_YPOS, machine_menu.LevelingParaConfTitle);
132
-  lv_refr_now(lv_refr_get_disp_refreshing());
125
+  scr = lv_screen_create(MANUAL_LEVELING_POSIGION_UI, machine_menu.LevelingParaConfTitle);
133 126
 
134 127
   if (uiCfg.para_ui_page != 1) {
135 128
     sprintf_P(public_buf_l, PSTR("%d"), gCfgItems.levelingPos[0][0]);

+ 1
- 9
Marlin/src/lcd/extui/lib/mks_ui/draw_max_feedrate_settings.cpp Bestand weergeven

@@ -90,15 +90,7 @@ static void event_handler(lv_obj_t *obj, lv_event_t event) {
90 90
 }
91 91
 
92 92
 void lv_draw_max_feedrate_settings(void) {
93
-  if (disp_state_stack._disp_state[disp_state_stack._disp_index] != MAXFEEDRATE_UI) {
94
-    disp_state_stack._disp_index++;
95
-    disp_state_stack._disp_state[disp_state_stack._disp_index] = MAXFEEDRATE_UI;
96
-  }
97
-  disp_state = MAXFEEDRATE_UI;
98
-
99
-  scr = lv_screen_create();
100
-  (void)lv_label_create(scr, TITLE_XPOS, TITLE_YPOS, machine_menu.MaxFeedRateConfTitle);
101
-  lv_refr_now(lv_refr_get_disp_refreshing());
93
+  scr = lv_screen_create(MAXFEEDRATE_UI, machine_menu.MaxFeedRateConfTitle);
102 94
 
103 95
   if (uiCfg.para_ui_page != 1) {
104 96
     sprintf_P(public_buf_l, PSTR("%.1f"), planner.settings.max_feedrate_mm_s[X_AXIS]);

+ 2
- 12
Marlin/src/lcd/extui/lib/mks_ui/draw_motor_settings.cpp Bestand weergeven

@@ -73,19 +73,9 @@ static void event_handler(lv_obj_t *obj, lv_event_t event) {
73 73
 }
74 74
 
75 75
 void lv_draw_motor_settings(void) {
76
-  if (disp_state_stack._disp_state[disp_state_stack._disp_index] != MOTOR_SETTINGS_UI) {
77
-    disp_state_stack._disp_index++;
78
-    disp_state_stack._disp_state[disp_state_stack._disp_index] = MOTOR_SETTINGS_UI;
79
-  }
80
-  disp_state = MOTOR_SETTINGS_UI;
81
-
82
-  scr = lv_screen_create();
83
-
84
-  (void)lv_label_create(scr, TITLE_XPOS, TITLE_YPOS, machine_menu.MotorConfTitle);
85
-
86
-  lv_refr_now(lv_refr_get_disp_refreshing());
87
-
88 76
   int index = 0;
77
+
78
+  scr = lv_screen_create(MOTOR_SETTINGS_UI, machine_menu.MotorConfTitle);
89 79
   lv_screen_menu_item(scr, machine_menu.StepsConf, PARA_UI_POS_X, PARA_UI_POS_Y, event_handler, ID_MOTOR_STEPS, index++);
90 80
   #if USE_SENSORLESS
91 81
     lv_screen_menu_item(scr, machine_menu.HomingSensitivityConf, PARA_UI_POS_X, PARA_UI_POS_Y * (index + 1), event_handler, ID_HOME_SENSE, index);

+ 1
- 12
Marlin/src/lcd/extui/lib/mks_ui/draw_move_motor.cpp Bestand weergeven

@@ -115,18 +115,7 @@ static void event_handler(lv_obj_t *obj, lv_event_t event) {
115 115
 }
116 116
 
117 117
 void lv_draw_move_motor(void) {
118
-  if (disp_state_stack._disp_state[disp_state_stack._disp_index] != MOVE_MOTOR_UI) {
119
-    disp_state_stack._disp_index++;
120
-    disp_state_stack._disp_state[disp_state_stack._disp_index] = MOVE_MOTOR_UI;
121
-  }
122
-  disp_state = MOVE_MOTOR_UI;
123
-
124
-  scr = lv_screen_create();
125
-
126
-  (void)lv_label_create(scr, TITLE_XPOS, TITLE_YPOS, creat_title_text());
127
-
128
-  lv_refr_now(lv_refr_get_disp_refreshing());
129
-
118
+  scr = lv_screen_create(MOVE_MOTOR_UI);
130 119
   lv_obj_t *buttonXI = lv_big_button_create(scr, "F:/bmp_xAdd.bin", move_menu.x_add, INTERVAL_V, titleHeight, event_handler, ID_M_X_P);
131 120
   lv_obj_clear_protect(buttonXI, LV_PROTECT_FOLLOW);
132 121
   lv_big_button_create(scr, "F:/bmp_xDec.bin", move_menu.x_dec, INTERVAL_V, BTN_Y_PIXEL + INTERVAL_H + titleHeight, event_handler, ID_M_X_N);

+ 1
- 11
Marlin/src/lcd/extui/lib/mks_ui/draw_number_key.cpp Bestand weergeven

@@ -662,17 +662,7 @@ static void event_handler(lv_obj_t *obj, lv_event_t event) {
662 662
 }
663 663
 
664 664
 void lv_draw_number_key(void) {
665
-  if (disp_state_stack._disp_state[disp_state_stack._disp_index] != NUMBER_KEY_UI) {
666
-    disp_state_stack._disp_index++;
667
-    disp_state_stack._disp_state[disp_state_stack._disp_index] = NUMBER_KEY_UI;
668
-  }
669
-  disp_state = NUMBER_KEY_UI;
670
-
671
-  scr = lv_screen_create();
672
-
673
-  //(void)lv_label_create(scr, TITLE_XPOS, TITLE_YPOS, creat_title_text());
674
-
675
-  lv_refr_now(lv_refr_get_disp_refreshing());
665
+  scr = lv_screen_create(NUMBER_KEY_UI, "");
676 666
 
677 667
   buttonValue = lv_btn_create(scr, 92, 40, 296, 40, event_handler, ID_NUM_KEY1, &style_num_text);
678 668
   labelValue = lv_label_create_empty(buttonValue);

+ 1
- 11
Marlin/src/lcd/extui/lib/mks_ui/draw_operation.cpp Bestand weergeven

@@ -129,17 +129,7 @@ void lv_draw_operation(void) {
129 129
            *buttonBabyStep = nullptr, *label_BabyStep = nullptr,
130 130
            *label_Filament = nullptr;
131 131
 
132
-  if (disp_state_stack._disp_state[disp_state_stack._disp_index] != OPERATE_UI) {
133
-    disp_state_stack._disp_index++;
134
-    disp_state_stack._disp_state[disp_state_stack._disp_index] = OPERATE_UI;
135
-  }
136
-  disp_state = OPERATE_UI;
137
-
138
-  scr = lv_screen_create();
139
-
140
-  (void)lv_label_create(scr, TITLE_XPOS, TITLE_YPOS, creat_title_text());
141
-
142
-  lv_refr_now(lv_refr_get_disp_refreshing());
132
+  scr = lv_screen_create(OPERATE_UI);
143 133
 
144 134
   // Create image buttons
145 135
   lv_obj_t *buttonPreHeat  = lv_imgbtn_create(scr, "F:/bmp_temp.bin", INTERVAL_V, titleHeight, event_handler, ID_O_PRE_HEAT);

+ 1
- 9
Marlin/src/lcd/extui/lib/mks_ui/draw_pause_position.cpp Bestand weergeven

@@ -65,15 +65,7 @@ static void event_handler(lv_obj_t *obj, lv_event_t event) {
65 65
 }
66 66
 
67 67
 void lv_draw_pause_position(void) {
68
-  if (disp_state_stack._disp_state[disp_state_stack._disp_index] != PAUSE_POS_UI) {
69
-    disp_state_stack._disp_index++;
70
-    disp_state_stack._disp_state[disp_state_stack._disp_index] = PAUSE_POS_UI;
71
-  }
72
-  disp_state = PAUSE_POS_UI;
73
-
74
-  scr = lv_screen_create();
75
-  (void)lv_label_create(scr, TITLE_XPOS, TITLE_YPOS, machine_menu.PausePosText);
76
-  lv_refr_now(lv_refr_get_disp_refreshing());
68
+  scr = lv_screen_create(PAUSE_POS_UI, machine_menu.PausePosText);
77 69
 
78 70
   sprintf_P(public_buf_l, PSTR("%.1f"), gCfgItems.pausePosX);
79 71
   lv_screen_menu_item_1_edit(scr, machine_menu.xPos, PARA_UI_POS_X, PARA_UI_POS_Y, event_handler, ID_PAUSE_X, 0, public_buf_l);

+ 1
- 11
Marlin/src/lcd/extui/lib/mks_ui/draw_preHeat.cpp Bestand weergeven

@@ -158,17 +158,7 @@ static void event_handler(lv_obj_t *obj, lv_event_t event) {
158 158
 }
159 159
 
160 160
 void lv_draw_preHeat(void) {
161
-  if (disp_state_stack._disp_state[disp_state_stack._disp_index] != PRE_HEAT_UI) {
162
-    disp_state_stack._disp_index++;
163
-    disp_state_stack._disp_state[disp_state_stack._disp_index] = PRE_HEAT_UI;
164
-  }
165
-  disp_state = PRE_HEAT_UI;
166
-
167
-  scr = lv_screen_create();
168
-
169
-  (void)lv_label_create(scr, TITLE_XPOS, TITLE_YPOS, creat_title_text());
170
-
171
-  lv_refr_now(lv_refr_get_disp_refreshing());
161
+  scr = lv_screen_create(PRE_HEAT_UI);
172 162
 
173 163
   // Create image buttons
174 164
   lv_big_button_create(scr, "F:/bmp_Add.bin", preheat_menu.add, INTERVAL_V, titleHeight, event_handler, ID_P_ADD);

+ 1
- 4
Marlin/src/lcd/extui/lib/mks_ui/draw_print_file.cpp Bestand weergeven

@@ -252,10 +252,7 @@ static char test_public_buf_l[40];
252 252
 void disp_gcode_icon(uint8_t file_num) {
253 253
   uint8_t i;
254 254
 
255
-  scr = lv_screen_create();
256
-  (void)lv_label_create(scr, TITLE_XPOS, TITLE_YPOS, creat_title_text());
257
-
258
-  lv_refr_now(lv_refr_get_disp_refreshing());
255
+  scr = lv_screen_create(MAIN_UI, "");
259 256
 
260 257
   // Create image buttons
261 258
   buttonPageUp   = lv_imgbtn_create(scr, "F:/bmp_pageUp.bin", OTHER_BTN_XPIEL * 3 + INTERVAL_V * 4, titleHeight, event_handler, ID_P_UP);

+ 1
- 9
Marlin/src/lcd/extui/lib/mks_ui/draw_printing.cpp Bestand weergeven

@@ -121,15 +121,7 @@ static void event_handler(lv_obj_t *obj, lv_event_t event) {
121 121
 void lv_draw_printing(void) {
122 122
   disp_state_stack._disp_index = 0;
123 123
   ZERO(disp_state_stack._disp_state);
124
-  disp_state_stack._disp_state[disp_state_stack._disp_index] = PRINTING_UI;
125
-
126
-  disp_state = PRINTING_UI;
127
-
128
-  scr = lv_screen_create();
129
-
130
-  (void)lv_label_create(scr, TITLE_XPOS, TITLE_YPOS, creat_title_text());
131
-
132
-  lv_refr_now(lv_refr_get_disp_refreshing());
124
+  scr = lv_screen_create(PRINTING_UI);
133 125
 
134 126
   // Create image buttons
135 127
   lv_obj_t *buttonExt1 = lv_img_create(scr, nullptr);

+ 1
- 6
Marlin/src/lcd/extui/lib/mks_ui/draw_ready_print.cpp Bestand weergeven

@@ -122,13 +122,8 @@ void lv_draw_ready_print(void) {
122 122
 
123 123
   disp_state_stack._disp_index = 0;
124 124
   ZERO(disp_state_stack._disp_state);
125
-  disp_state_stack._disp_state[disp_state_stack._disp_index] = PRINT_READY_UI;
126
-
127
-  disp_state = PRINT_READY_UI;
128
-
129
-  scr = lv_screen_create();
125
+  scr = lv_screen_create(PRINT_READY_UI, "");
130 126
   //lv_obj_set_hidden(scr, true);
131
-  lv_refr_now(lv_refr_get_disp_refreshing());
132 127
 
133 128
   if (mks_test_flag == 0x1E) {
134 129
     //(void)lv_label_create(scr, TITLE_XPOS, TITLE_YPOS, creat_title_text());

+ 1
- 12
Marlin/src/lcd/extui/lib/mks_ui/draw_set.cpp Bestand weergeven

@@ -126,18 +126,7 @@ static void event_handler(lv_obj_t *obj, lv_event_t event) {
126 126
 }
127 127
 
128 128
 void lv_draw_set(void) {
129
-  if (disp_state_stack._disp_state[disp_state_stack._disp_index] != SET_UI) {
130
-    disp_state_stack._disp_index++;
131
-    disp_state_stack._disp_state[disp_state_stack._disp_index] = SET_UI;
132
-  }
133
-  disp_state = SET_UI;
134
-
135
-  scr = lv_screen_create();
136
-
137
-  (void)lv_label_create(scr, TITLE_XPOS, TITLE_YPOS, creat_title_text());
138
-
139
-  lv_refr_now(lv_refr_get_disp_refreshing());
140
-
129
+  scr = lv_screen_create(SET_UI);
141 130
   lv_big_button_create(scr, "F:/bmp_eeprom_settings.bin", set_menu.eepromSet, INTERVAL_V, titleHeight, event_handler, ID_S_EEPROM_SET);
142 131
   lv_big_button_create(scr, "F:/bmp_fan.bin", set_menu.fan, BTN_X_PIXEL + INTERVAL_V * 2, titleHeight, event_handler, ID_S_FAN);
143 132
   lv_big_button_create(scr, "F:/bmp_about.bin", set_menu.about, BTN_X_PIXEL * 2 + INTERVAL_V * 3, titleHeight, event_handler, ID_S_ABOUT);

+ 1
- 9
Marlin/src/lcd/extui/lib/mks_ui/draw_step_settings.cpp Bestand weergeven

@@ -90,15 +90,7 @@ static void event_handler(lv_obj_t *obj, lv_event_t event) {
90 90
 }
91 91
 
92 92
 void lv_draw_step_settings(void) {
93
-  if (disp_state_stack._disp_state[disp_state_stack._disp_index] != STEPS_UI) {
94
-    disp_state_stack._disp_index++;
95
-    disp_state_stack._disp_state[disp_state_stack._disp_index] = STEPS_UI;
96
-  }
97
-  disp_state = STEPS_UI;
98
-
99
-  scr = lv_screen_create();
100
-  (void)lv_label_create(scr, TITLE_XPOS, TITLE_YPOS, machine_menu.StepsConfTitle);
101
-  lv_refr_now(lv_refr_get_disp_refreshing());
93
+  scr = lv_screen_create(STEPS_UI, machine_menu.StepsConfTitle);
102 94
 
103 95
   if (uiCfg.para_ui_page != 1) {
104 96
     sprintf_P(public_buf_l, PSTR("%.1f"), planner.settings.axis_steps_per_mm[X_AXIS]);

+ 1
- 9
Marlin/src/lcd/extui/lib/mks_ui/draw_tmc_current_settings.cpp Bestand weergeven

@@ -103,15 +103,7 @@ static void event_handler(lv_obj_t *obj, lv_event_t event) {
103 103
 }
104 104
 
105 105
 void lv_draw_tmc_current_settings(void) {
106
-  if (disp_state_stack._disp_state[disp_state_stack._disp_index] != TMC_CURRENT_UI) {
107
-    disp_state_stack._disp_index++;
108
-    disp_state_stack._disp_state[disp_state_stack._disp_index] = TMC_CURRENT_UI;
109
-  }
110
-  disp_state = TMC_CURRENT_UI;
111
-
112
-  scr = lv_screen_create();
113
-  (void)lv_label_create(scr, TITLE_XPOS, TITLE_YPOS, machine_menu.TmcCurrentConfTitle);
114
-  lv_refr_now(lv_refr_get_disp_refreshing());
106
+  scr = lv_screen_create(TMC_CURRENT_UI, machine_menu.TmcCurrentConfTitle);
115 107
 
116 108
   float milliamps;
117 109
   if (uiCfg.para_ui_page != 1) {

+ 1
- 9
Marlin/src/lcd/extui/lib/mks_ui/draw_tmc_step_mode_settings.cpp Bestand weergeven

@@ -112,15 +112,7 @@ static void event_handler(lv_obj_t *obj, lv_event_t event) {
112 112
 void lv_draw_tmc_step_mode_settings(void) {
113 113
   buttonXState = buttonYState = buttonZState = buttonE0State = buttonE1State = nullptr;
114 114
 
115
-  if (disp_state_stack._disp_state[disp_state_stack._disp_index] != TMC_MODE_UI) {
116
-    disp_state_stack._disp_index++;
117
-    disp_state_stack._disp_state[disp_state_stack._disp_index] = TMC_MODE_UI;
118
-  }
119
-  disp_state = TMC_MODE_UI;
120
-
121
-  scr = lv_screen_create();
122
-  (void)lv_label_create(scr, TITLE_XPOS, TITLE_YPOS, machine_menu.TmcStepModeConfTitle);
123
-  lv_refr_now(lv_refr_get_disp_refreshing());
115
+  scr = lv_screen_create(TMC_MODE_UI, machine_menu.TmcStepModeConfTitle);
124 116
 
125 117
   bool stealth_X = false, stealth_Y = false, stealth_Z = false, stealth_E0 = false, stealth_E1 = false;
126 118
   #if AXIS_HAS_STEALTHCHOP(X)

+ 1
- 14
Marlin/src/lcd/extui/lib/mks_ui/draw_tool.cpp Bestand weergeven

@@ -99,24 +99,11 @@ static void event_handler(lv_obj_t *obj, lv_event_t event) {
99 99
 }
100 100
 
101 101
 void lv_draw_tool(void) {
102
-  if (disp_state_stack._disp_state[disp_state_stack._disp_index] != TOOL_UI) {
103
-    disp_state_stack._disp_index++;
104
-    disp_state_stack._disp_state[disp_state_stack._disp_index] = TOOL_UI;
105
-  }
106
-  disp_state = TOOL_UI;
107
-
108
-  scr = lv_screen_create();
109
-
110
-  (void)lv_label_create(scr, TITLE_XPOS, TITLE_YPOS, creat_title_text());
111
-
112
-  lv_refr_now(lv_refr_get_disp_refreshing());
113
-
102
+  scr = lv_screen_create(TOOL_UI);
114 103
   lv_big_button_create(scr, "F:/bmp_preHeat.bin", tool_menu.preheat, INTERVAL_V, titleHeight, event_handler, ID_T_PRE_HEAT);
115 104
   lv_big_button_create(scr, "F:/bmp_extruct.bin", tool_menu.extrude, BTN_X_PIXEL + INTERVAL_V * 2, titleHeight, event_handler, ID_T_EXTRUCT);
116
-
117 105
   lv_big_button_create(scr, "F:/bmp_mov.bin", tool_menu.move, BTN_X_PIXEL * 2 + INTERVAL_V * 3, titleHeight, event_handler, ID_T_MOV);
118 106
   lv_big_button_create(scr, "F:/bmp_zero.bin", tool_menu.home, BTN_X_PIXEL * 3 + INTERVAL_V * 4, titleHeight, event_handler, ID_T_HOME);
119
-
120 107
   lv_big_button_create(scr, "F:/bmp_leveling.bin", tool_menu.TERN(AUTO_BED_LEVELING_BILINEAR, autoleveling, leveling), INTERVAL_V, BTN_Y_PIXEL + INTERVAL_H + titleHeight, event_handler, ID_T_LEVELING);
121 108
   lv_big_button_create(scr, "F:/bmp_filamentchange.bin", tool_menu.filament, BTN_X_PIXEL+INTERVAL_V*2,BTN_Y_PIXEL+INTERVAL_H+titleHeight, event_handler,ID_T_FILAMENT);
122 109
   lv_big_button_create(scr, "F:/bmp_return.bin", common_menu.text_back, BTN_X_PIXEL * 3 + INTERVAL_V * 4, BTN_Y_PIXEL + INTERVAL_H + titleHeight, event_handler, ID_T_RETURN);

+ 19
- 1
Marlin/src/lcd/extui/lib/mks_ui/draw_ui.cpp Bestand weergeven

@@ -1628,11 +1628,29 @@ void lv_btn_set_style_both(lv_obj_t *btn, lv_style_t *style) {
1628 1628
 }
1629 1629
 
1630 1630
 // Create a screen
1631
-lv_obj_t* lv_screen_create() {
1631
+lv_obj_t* lv_screen_create(DISP_STATE newScreenType, const char* title) {
1632 1632
   lv_obj_t *scr = lv_obj_create(nullptr, nullptr);
1633 1633
   lv_obj_set_style(scr, &tft_style_scr);
1634 1634
   lv_scr_load(scr);
1635 1635
   lv_obj_clean(scr);
1636
+
1637
+  // breadcrumbs
1638
+  if (disp_state_stack._disp_state[disp_state_stack._disp_index] != newScreenType) {
1639
+    disp_state_stack._disp_index++;
1640
+    disp_state_stack._disp_state[disp_state_stack._disp_index] = newScreenType;
1641
+  }
1642
+  disp_state = newScreenType;
1643
+  lv_refr_now(lv_refr_get_disp_refreshing());
1644
+
1645
+  // title
1646
+  lv_obj_t *titleLabel = nullptr;
1647
+  if (!title)
1648
+    titleLabel = lv_label_create(scr, TITLE_XPOS, TITLE_YPOS, creat_title_text());
1649
+  else if (title[0] != '\0')
1650
+    titleLabel = lv_label_create(scr, TITLE_XPOS, TITLE_YPOS, title);
1651
+  if (titleLabel)
1652
+    lv_obj_set_style(titleLabel, &tft_style_label_rel);
1653
+
1636 1654
   return scr;
1637 1655
 }
1638 1656
 

+ 1
- 1
Marlin/src/lcd/extui/lib/mks_ui/draw_ui.h Bestand weergeven

@@ -468,7 +468,7 @@ void lv_btn_use_label_style(lv_obj_t *btn);
468 468
 void lv_btn_set_style_both(lv_obj_t *btn, lv_style_t *style);
469 469
 
470 470
 // Create a screen
471
-lv_obj_t* lv_screen_create();
471
+lv_obj_t* lv_screen_create(DISP_STATE newScreenType, const char* title = nullptr);
472 472
 
473 473
 // Create an empty label
474 474
 lv_obj_t* lv_label_create_empty(lv_obj_t *par);

+ 1
- 11
Marlin/src/lcd/extui/lib/mks_ui/draw_wifi.cpp Bestand weergeven

@@ -58,17 +58,7 @@ static void event_handler(lv_obj_t *obj, lv_event_t event) {
58 58
 }
59 59
 
60 60
 void lv_draw_wifi(void) {
61
-  if (disp_state_stack._disp_state[disp_state_stack._disp_index] != WIFI_UI) {
62
-    disp_state_stack._disp_index++;
63
-    disp_state_stack._disp_state[disp_state_stack._disp_index] = WIFI_UI;
64
-  }
65
-  disp_state = WIFI_UI;
66
-
67
-  scr = lv_screen_create();
68
-
69
-  (void)lv_label_create(scr, TITLE_XPOS, TITLE_YPOS, creat_title_text());
70
-
71
-  lv_refr_now(lv_refr_get_disp_refreshing());
61
+  scr = lv_screen_create(WIFI_UI);
72 62
 
73 63
   // Create an Image button
74 64
   lv_obj_t *buttonBack = lv_imgbtn_create(scr, "F:/bmp_return.bin", BTN_X_PIXEL * 3 + INTERVAL_V * 4, BTN_Y_PIXEL + INTERVAL_H + titleHeight, event_handler, ID_W_RETURN);

+ 1
- 11
Marlin/src/lcd/extui/lib/mks_ui/draw_wifi_list.cpp Bestand weergeven

@@ -89,17 +89,7 @@ static void event_handler(lv_obj_t *obj, lv_event_t event) {
89 89
 }
90 90
 
91 91
 void lv_draw_wifi_list(void) {
92
-  if (disp_state_stack._disp_state[disp_state_stack._disp_index] != WIFI_LIST_UI) {
93
-    disp_state_stack._disp_index++;
94
-    disp_state_stack._disp_state[disp_state_stack._disp_index] = WIFI_LIST_UI;
95
-  }
96
-  disp_state = WIFI_LIST_UI;
97
-
98
-  scr = lv_screen_create();
99
-
100
-  (void)lv_label_create(scr, TITLE_XPOS, TITLE_YPOS, creat_title_text());
101
-
102
-  lv_refr_now(lv_refr_get_disp_refreshing());
92
+  scr = lv_screen_create(WIFI_LIST_UI);
103 93
 
104 94
   lv_obj_t *buttonDown = lv_imgbtn_create(scr, "F:/bmp_pageDown.bin", OTHER_BTN_XPIEL * 3 + INTERVAL_V * 4, titleHeight + OTHER_BTN_YPIEL + INTERVAL_H, event_handler, ID_WL_DOWN);
105 95
   lv_obj_t *buttonBack = lv_imgbtn_create(scr, "F:/bmp_back.bin", OTHER_BTN_XPIEL * 3 + INTERVAL_V * 4, titleHeight + (OTHER_BTN_YPIEL + INTERVAL_H) * 2, event_handler, ID_WL_RETURN);

+ 1
- 11
Marlin/src/lcd/extui/lib/mks_ui/draw_wifi_settings.cpp Bestand weergeven

@@ -94,17 +94,7 @@ static void event_handler(lv_obj_t *obj, lv_event_t event) {
94 94
 }
95 95
 
96 96
 void lv_draw_wifi_settings(void) {
97
-  if (disp_state_stack._disp_state[disp_state_stack._disp_index] != WIFI_SETTINGS_UI) {
98
-    disp_state_stack._disp_index++;
99
-    disp_state_stack._disp_state[disp_state_stack._disp_index] = WIFI_SETTINGS_UI;
100
-  }
101
-  disp_state = WIFI_SETTINGS_UI;
102
-
103
-  scr = lv_screen_create();
104
-
105
-  (void)lv_label_create(scr, TITLE_XPOS, TITLE_YPOS, machine_menu.WifiConfTitle);
106
-
107
-  lv_refr_now(lv_refr_get_disp_refreshing());
97
+  scr = lv_screen_create(WIFI_SETTINGS_UI, machine_menu.WifiConfTitle);
108 98
 
109 99
   lv_obj_t *labelModelText = lv_label_create(scr, PARA_UI_POS_X, PARA_UI_POS_Y + 10, machine_menu.wifiMode);
110 100
 

+ 1
- 8
Marlin/src/lcd/extui/lib/mks_ui/draw_wifi_tips.cpp Bestand weergeven

@@ -39,14 +39,7 @@ tips_menu_def tips_menu;
39 39
 void lv_draw_wifi_tips(void) {
40 40
   static lv_obj_t *text_tips,*wifi_name;
41 41
 
42
-  if (disp_state_stack._disp_state[disp_state_stack._disp_index] != WIFI_TIPS_UI) {
43
-    disp_state_stack._disp_index++;
44
-    disp_state_stack._disp_state[disp_state_stack._disp_index] = WIFI_TIPS_UI;
45
-  }
46
-  disp_state = WIFI_TIPS_UI;
47
-
48
-  scr = lv_screen_create();
49
-  lv_refr_now(lv_refr_get_disp_refreshing());
42
+  scr = lv_screen_create(WIFI_TIPS_UI, "");
50 43
 
51 44
   wifi_name = lv_label_create(scr, (const char *)wifi_list.wifiName[wifi_list.nameIndex]);
52 45
   lv_obj_align(wifi_name, nullptr, LV_ALIGN_CENTER, 0, -20);

+ 1
- 1
Marlin/src/lcd/extui/lib/mks_ui/wifiSerial.cpp Bestand weergeven

@@ -53,7 +53,7 @@ WifiSerial::WifiSerial(usart_dev *usart_device, uint8 tx_pin, uint8 rx_pin) {
53 53
   /* F1 MCUs have no GPIO_AFR[HL], so turn off PWM if there's a conflict
54 54
    * on this GPIO bit. */
55 55
   static void disable_timer_if_necessary(timer_dev *dev, uint8 ch) {
56
-    if (dev != nullptr) timer_set_mode(dev, ch, TIMER_DISABLED);
56
+    if (dev) timer_set_mode(dev, ch, TIMER_DISABLED);
57 57
   }
58 58
 #elif STM32_MCU_SERIES == STM32_SERIES_F2 || STM32_MCU_SERIES == STM32_SERIES_F4
59 59
   #define disable_timer_if_necessary(dev, ch) ((void)0)

+ 2
- 6
Marlin/src/lcd/extui/lib/mks_ui/wifi_upload.cpp Bestand weergeven

@@ -533,12 +533,8 @@ EspUploadResult flashFinish(signed char reboot) {
533 533
 
534 534
 // Compute the checksum of a block of data
535 535
 uint16_t checksum(const uint8_t *data, uint16_t dataLen, uint16_t cksum) {
536
-  if (data != nullptr) {
537
-    while (dataLen--) {
538
-      cksum ^= (uint16_t)*data++;
539
-    }
540
-  }
541
-  return(cksum);
536
+  if (data) while (dataLen--) cksum ^= (uint16_t)*data++;
537
+  return cksum;
542 538
 }
543 539
 
544 540
 EspUploadResult flashWriteBlock(uint16_t flashParmVal, uint16_t flashParmMask) {

Laden…
Annuleren
Opslaan