Browse Source

Add disclaimer for verboten parameters

Scott Lahteine 8 years ago
parent
commit
ba29da56e0
2 changed files with 12 additions and 11 deletions
  1. 2
    2
      Marlin/G26_Mesh_Validation_Tool.cpp
  2. 10
    9
      Marlin/ubl_G29.cpp

+ 2
- 2
Marlin/G26_Mesh_Validation_Tool.cpp View File

686
       }
686
       }
687
     }
687
     }
688
 
688
 
689
-    if (code_seen('N') || code_seen('n')) {
689
+    if (code_seen('N') || code_seen('n')) { // Warning! Use of 'N' / lowercase flouts established standards.
690
       nozzle = code_value_float();
690
       nozzle = code_value_float();
691
       if (!WITHIN(nozzle, 0.1, 1.0)) {
691
       if (!WITHIN(nozzle, 0.1, 1.0)) {
692
         SERIAL_PROTOCOLLNPGM("?Specified nozzle size not plausible.");
692
         SERIAL_PROTOCOLLNPGM("?Specified nozzle size not plausible.");
728
       }
728
       }
729
     }
729
     }
730
 
730
 
731
-    if (code_seen('M')) {
731
+    if (code_seen('M')) { // Warning! Use of 'M' flouts established standards.
732
       randomSeed(millis());
732
       randomSeed(millis());
733
       // This setting will persist for the next G26
733
       // This setting will persist for the next G26
734
       random_deviation = code_has_value() ? code_value_float() : 50.0;
734
       random_deviation = code_has_value() ? code_value_float() : 50.0;

+ 10
- 9
Marlin/ubl_G29.cpp View File

328
       return;
328
       return;
329
     }
329
     }
330
 
330
 
331
-    if (!code_seen('N') && axis_unhomed_error(true, true, true))  // Don't allow auto-leveling without homing first
331
+    // Don't allow auto-leveling without homing first
332
+    if (!code_seen('N') && axis_unhomed_error(true, true, true)) // Warning! Use of 'N' flouts established standards.
332
       home_all_axes();
333
       home_all_axes();
333
 
334
 
334
     if (g29_parameter_parsing()) return; // abort if parsing the simple parameters causes a problem,
335
     if (g29_parameter_parsing()) return; // abort if parsing the simple parameters causes a problem,
385
 
386
 
386
     if (code_seen('J')) {
387
     if (code_seen('J')) {
387
       ubl.save_ubl_active_state_and_disable();
388
       ubl.save_ubl_active_state_and_disable();
388
-      ubl.tilt_mesh_based_on_probed_grid(code_seen('O') || code_seen('M'));
389
+      ubl.tilt_mesh_based_on_probed_grid(code_seen('O') || code_seen('M')); // Warning! Use of 'M' flouts established standards.
389
       ubl.restore_ubl_active_state_and_leave();
390
       ubl.restore_ubl_active_state_and_leave();
390
     }
391
     }
391
 
392
 
419
             SERIAL_PROTOCOLLNPGM(").\n");
420
             SERIAL_PROTOCOLLNPGM(").\n");
420
           }
421
           }
421
           ubl.probe_entire_mesh(x_pos + X_PROBE_OFFSET_FROM_EXTRUDER, y_pos + Y_PROBE_OFFSET_FROM_EXTRUDER,
422
           ubl.probe_entire_mesh(x_pos + X_PROBE_OFFSET_FROM_EXTRUDER, y_pos + Y_PROBE_OFFSET_FROM_EXTRUDER,
422
-                            code_seen('O') || code_seen('M'), code_seen('E'), code_seen('U'));
423
+                            code_seen('O') || code_seen('M'), code_seen('E'), code_seen('U')); // Warning! Use of 'M' flouts established standards.
423
           break;
424
           break;
424
 
425
 
425
         case 2: {
426
         case 2: {
468
             return;
469
             return;
469
           }
470
           }
470
 
471
 
471
-          manually_probe_remaining_mesh(x_pos, y_pos, height, card_thickness, code_seen('O') || code_seen('M'));
472
+          manually_probe_remaining_mesh(x_pos, y_pos, height, card_thickness, code_seen('O') || code_seen('M')); // Warning! Use of 'M' flouts established standards.
472
           SERIAL_PROTOCOLLNPGM("G29 P2 finished.");
473
           SERIAL_PROTOCOLLNPGM("G29 P2 finished.");
473
         } break;
474
         } break;
474
 
475
 
504
           //
505
           //
505
           // Fine Tune (i.e., Edit) the Mesh
506
           // Fine Tune (i.e., Edit) the Mesh
506
           //
507
           //
507
-          fine_tune_mesh(x_pos, y_pos, code_seen('O') || code_seen('M'));
508
+          fine_tune_mesh(x_pos, y_pos, code_seen('O') || code_seen('M')); // Warning! Use of 'M' flouts established standards.
508
           break;
509
           break;
509
 
510
 
510
         case 5: ubl.find_mean_mesh_height(); break;
511
         case 5: ubl.find_mean_mesh_height(); break;
549
     // When we are fully debugged, the EEPROM dump command will get deleted also. But
550
     // When we are fully debugged, the EEPROM dump command will get deleted also. But
550
     // right now, it is good to have the extra information. Soon... we prune this.
551
     // right now, it is good to have the extra information. Soon... we prune this.
551
     //
552
     //
552
-    if (code_seen('j')) g29_eeprom_dump();   // EEPROM Dump
553
+    if (code_seen('j')) g29_eeprom_dump(); // Warning! Use of lowercase flouts established standards.
553
 
554
 
554
     //
555
     //
555
     // When we are fully debugged, this may go away. But there are some valid
556
     // When we are fully debugged, this may go away. But there are some valid
613
       SERIAL_PROTOCOLLNPGM("Done.\n");
614
       SERIAL_PROTOCOLLNPGM("Done.\n");
614
     }
615
     }
615
 
616
 
616
-    if (code_seen('O') || code_seen('M'))
617
+    if (code_seen('O') || code_seen('M')) // Warning! Use of 'M' flouts established standards.
617
       ubl.display_map(code_has_value() ? code_value_int() : 0);
618
       ubl.display_map(code_has_value() ? code_value_int() : 0);
618
 
619
 
619
     if (code_seen('Z')) {
620
     if (code_seen('Z')) {
1128
       SERIAL_PROTOCOLLNPGM("Invalid map type.\n");
1129
       SERIAL_PROTOCOLLNPGM("Invalid map type.\n");
1129
       return UBL_ERR;
1130
       return UBL_ERR;
1130
     }
1131
     }
1131
-
1132
+    // Check if a map type was specified
1132
-    if (code_seen('M')) {     // Check if a map type was specified
1133
+    if (code_seen('M')) { // Warning! Use of 'M' flouts established standards.
1133
       map_type = code_has_value() ? code_value_int() : 0;
1134
       map_type = code_has_value() ? code_value_int() : 0;
1134
       if (!WITHIN(map_type, 0, 1)) {
1135
       if (!WITHIN(map_type, 0, 1)) {
1135
         SERIAL_PROTOCOLLNPGM("Invalid map type.\n");
1136
         SERIAL_PROTOCOLLNPGM("Invalid map type.\n");

Loading…
Cancel
Save