Browse Source

Add probe_switch_activated

Scott Lahteine 4 years ago
parent
commit
f423edd938

+ 3
- 6
Marlin/src/module/endstops.cpp View File

@@ -465,7 +465,7 @@ void _O2 Endstops::report_states() {
465 465
     ES_REPORT(Z4_MAX);
466 466
   #endif
467 467
   #if BOTH(MARLIN_DEV_MODE, PROBE_ACTIVATION_SWITCH)
468
-    print_es_state(READ(PROBE_ACTIVATION_SWITCH_PIN) == PROBE_ACTIVATION_SWITCH_STATE, PSTR(STR_PROBE_EN));
468
+    print_es_state(probe_switch_activated(), PSTR(STR_PROBE_EN));
469 469
   #endif
470 470
   #if HAS_CUSTOM_PROBE_PIN
471 471
     print_es_state(PROBE_TRIGGERED(), PSTR(STR_Z_PROBE));
@@ -618,11 +618,8 @@ void Endstops::update() {
618 618
 
619 619
   #if HAS_BED_PROBE
620 620
     // When closing the gap check the enabled probe
621
-    if (true
622
-      #if ENABLED(PROBE_ACTIVATION_SWITCH)
623
-        || READ(PROBE_ACTIVATION_SWITCH_PIN) == PROBE_ACTIVATION_SWITCH_STATE
624
-      #endif
625
-    ) UPDATE_ENDSTOP_BIT(Z, TERN(HAS_CUSTOM_PROBE_PIN, MIN_PROBE, MIN));
621
+    if (probe_switch_activated())
622
+      UPDATE_ENDSTOP_BIT(Z, TERN(HAS_CUSTOM_PROBE_PIN, MIN_PROBE, MIN));
626 623
   #endif
627 624
 
628 625
   #if HAS_Z_MAX && !Z_SPI_SENSORLESS

+ 8
- 0
Marlin/src/module/endstops.h View File

@@ -116,6 +116,14 @@ class Endstops {
116 116
       ;
117 117
     }
118 118
 
119
+    static inline bool probe_switch_activated() {
120
+      return (true
121
+        #if ENABLED(PROBE_ACTIVATION_SWITCH)
122
+          && READ(PROBE_ACTIVATION_SWITCH_PIN) == PROBE_ACTIVATION_SWITCH_STATE
123
+        #endif
124
+      );
125
+    }
126
+
119 127
     /**
120 128
      * Report endstop hits to serial. Called from loop().
121 129
      */

+ 1
- 1
Marlin/src/module/probe.cpp View File

@@ -519,7 +519,7 @@ bool Probe::probe_down_to_z(const float z, const feedRate_t fr_mm_s) {
519 519
    */
520 520
   bool Probe::tare() {
521 521
     #if BOTH(PROBE_ACTIVATION_SWITCH, PROBE_TARE_ONLY_WHILE_INACTIVE)
522
-      if (READ(PROBE_ACTIVATION_SWITCH_PIN) == PROBE_ACTIVATION_SWITCH_STATE) {
522
+      if (endstops.probe_switch_activated()) {
523 523
         SERIAL_ECHOLNPGM("Cannot tare an active probe");
524 524
         return true;
525 525
       }

+ 1
- 1
buildroot/tests/STM32F103RET6_creality-tests View File

@@ -23,7 +23,7 @@ opt_set SERIAL_PORT 1
23 23
 opt_set MOTHERBOARD BOARD_CREALITY_V452
24 24
 opt_disable NOZZLE_TO_PROBE_OFFSET
25 25
 opt_enable NOZZLE_AS_PROBE Z_SAFE_HOMING Z_MIN_PROBE_USES_Z_MIN_ENDSTOP_PIN
26
-opt_enable PROBE_ACTIVATION_SWITCH PROBE_ACTIVATION_SWITCH_PIN PROBE_TARE PROBE_TARE_ONLY_WHILE_INACTIVE
26
+opt_enable PROBE_ACTIVATION_SWITCH PROBE_TARE PROBE_TARE_ONLY_WHILE_INACTIVE
27 27
 exec_test $1 $2 "Creality V4.5.2 PROBE_ACTIVATION_SWITCH, Probe Tare" "$3"
28 28
 
29 29
 # clean up

Loading…
Cancel
Save